Fix default endpoint for stub responses

Author: Matt Muller

gems/smithy-client/lib/smithy-client/plugins/stub_responses.rb

@@ -29,13 +29,6 @@ def add_handlers(handlers, config)
           handlers.add(StubHandler, step: :send)
         end
 
-        def before_initialize(_client_class, options)
-          return unless options[:stub_responses]
-          return if options.key?(:endpoint) || options.key?(:endpoint_provider)
-
-          options[:endpoint] = 'http://stubbed-endpoint'
-        end
-
         def after_initialize(client)
           return unless client.config.stub_responses
 

gems/smithy-client/spec/smithy-client/plugins/stub_responses_spec.rb

@@ -41,13 +41,6 @@ module Plugins
           expect(client.config.endpoint).to eq('https://example.com')
         end
 
-        it 'does not default the endpoint if a custom endpoint provider is set' do
-          endpoint_provider = double('endpoint-provider')
-          client = client_class.new(stub_responses: true, endpoint_provider: endpoint_provider)
-          expect(client.config.endpoint_provider).to be(endpoint_provider)
-          expect(client.config.endpoint).to be_nil
-        end
-
         it 'signals error for exceptions' do
           expect_any_instance_of(Http::Response).to receive(:signal_error)
           client.stub_responses(:operation, RuntimeError.new('error'))

gems/smithy/lib/smithy/templates/client/endpoint_plugin.erb

@@ -37,6 +37,12 @@ module <%= module_name %>
         <%= endpoint_auth_scheme_bindings %>
       end
 
+      def before_initialize(_client_class, options)
+        return unless options[:stub_responses]
+
+        options[:endpoint] = 'http://stubbed-endpoint' unless options.key?(:endpoint)
+      end
+
       # @api private
       class Handler < Smithy::Client::Handler
         def call(context)

gems/smithy/lib/smithy/templates/client/endpoint_provider_spec.erb

@@ -32,6 +32,7 @@ module <%= module_name %>
       it 'produces the correct output from the client when calling <%= operation_input.operation_name %>' do
         client = Client.new(
           stub_responses: true,
+          endpoint: nil,
           endpoint_provider: subject,
 <% operation_input.client_params.each do |p| -%>
           <%= p.param %>: <%= p.value %>,