Create TimeHelper module

Author: jterapin

gems/smithy-schema/lib/smithy-schema.rb

@@ -3,6 +3,7 @@
 require_relative 'smithy-schema/shapes'
 require_relative 'smithy-schema/structure'
 require_relative 'smithy-schema/document'
+require_relative 'smithy-schema/time_helper'
 require_relative 'smithy-schema/type_registry'
 require_relative 'smithy-schema/union'
 

gems/smithy-schema/lib/smithy-schema/document_utils.rb

@@ -96,7 +96,7 @@ def apply_structure(data, shape, type)
 
         def apply_timestamp(data, shape)
           data = data.is_a?(Numeric) ? Time.at(data) : Time.parse(data)
-          time(data, timestamp_format(shape))
+          TimeHelper.time(data, timestamp_format(shape))
         end
 
         def apply_union(data, shape, type)
@@ -147,8 +147,8 @@ def extract_structure(data, shape, opts)
         def extract_timestamp(data, shape, opts)
           return unless data.is_a?(Time)
 
-          trait = timestamp_format(shape) if opts[:use_timestamp_format]
-          time(data, trait)
+          trait = opts[:use_timestamp_format] ? timestamp_format(shape) : 'epoch-seconds'
+          TimeHelper.time(data, trait)
         end
 
         # rubocop:disable Metrics/AbcSize
@@ -208,23 +208,6 @@ def timestamp_format(shape)
             'epoch-seconds'
           end
         end
-
-        def time(data, trait = nil)
-          if trait
-            case trait
-            when 'http-date'
-              data.utc.iso8601
-            when 'date-time'
-              data.utc.httpdate
-            when 'epoch-seconds'
-              data.utc.to_i
-            else
-              raise "unhandled timestamp format `#{value}`"
-            end
-          else
-            data.utc.to_i # default format
-          end
-        end
       end
     end
   end

gems/smithy-schema/lib/smithy-schema/time_helper.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Smithy
+  module Schema
+    # A module that provides helper methods to convert Time objects
+    # based on the given TimestampFormat trait.
+    # @api private
+    module TimeHelper
+      class << self
+        # @param [Time] time
+        # @param [String] trait TimestampFormat trait value
+        # @return [Object] The time as TimestampFormat trait format
+        def time(time, trait)
+          raise ArgumentError, 'expected Time as input' unless time.is_a?(Time)
+
+          case trait
+          when 'http-date'
+            time.utc.iso8601
+          when 'date-time'
+            time.utc.httpdate
+          when 'epoch-seconds'
+            time.utc.to_i
+          else
+            raise ArgumentError, "unhandled timestamp format `#{trait}`"
+          end
+        end
+      end
+    end
+  end
+end

gems/smithy-schema/spec/smithy-schema/time_helper_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require_relative '../spec_helper'
+require 'time'
+
+module Smithy
+  module Schema
+    describe TimeHelper do
+      describe '#time' do
+        let(:time) { Time.new(2002, 10, 31) }
+
+        it 'returns as http-date format' do
+          expect(subject.time(time, 'http-date')).to eq('2002-10-31T08:00:00Z')
+        end
+
+        it 'returns as date-time format' do
+          expect(subject.time(time, 'date-time')).to eq('Thu, 31 Oct 2002 08:00:00 GMT')
+        end
+
+        it 'returns as epoch-seconds format' do
+          expect(subject.time(time, 'epoch-seconds')).to eq(1_036_051_200)
+        end
+
+        it 'raises when given time is invalid ' do
+          expect { subject.time('time', 'http-date') }.to raise_error(ArgumentError)
+        end
+
+        it 'raises when given timestamp trait is unhandled' do
+          expect { subject.time(time, 'foo') }.to raise_error(ArgumentError)
+        end
+      end
+    end
+  end
+end