Preprocess error type

Author: richardwang1124

gems/smithy-client/lib/smithy-client/waiters/poller.rb

@@ -70,8 +70,7 @@ def matches_success?(path_matcher, output, error)
         def matches_errorType?(path_matcher, output, error) # rubocop:disable Naming/MethodName
           return false unless output.nil?
 
-          err = path_matcher.split('#').last.split('#').first
-          error.class.to_s.include?(err)
+          error.class.to_s.include?(path_matcher)
         end
 
         def equal?(actual, expected, comparator)

gems/smithy-client/spec/smithy-client/waiters_spec.rb

@@ -400,17 +400,34 @@ module Waiters
                       }
                     }
                   ]
+                },
+                'AbsoluteErrorTypeMatcher' => {
+                  'acceptors' => [
+                    {
+                      'state' => 'success',
+                      'matcher' => {
+                        'errorType' => 'smithy.ruby.tests#MyError'
+                      }
+                    }
+                  ]
                 }
               }
             end
 
-            it 'succeeds when error matches' do
+            it 'succeeds when error matches for relative shape name' do
               expect(client).to receive(:get_widget).and_raise(my_error)
               expect do
                 client.wait_until(:error_type_matcher, input, max_wait_time: 60)
               end.to_not raise_error
             end
 
+            it 'succeeds when error matches for absolute shape id' do
+              expect(client).to receive(:get_widget).and_raise(my_error)
+              expect do
+                client.wait_until(:absolute_error_type_matcher, input, max_wait_time: 60)
+              end.to_not raise_error
+            end
+
             it 'retries and succeeds when matched' do
               output = {}
               2.times do

gems/smithy/lib/smithy/views/client/waiters.rb

@@ -51,11 +51,7 @@ def initialize(operation, name, waiter)
           attr_reader :operation_name, :name, :documentation, :acceptors, :min_delay, :max_delay, :deprecated
 
           def formatted_acceptors(acceptors)
-            acceptors.each do |acceptor|
-              if (matcher = acceptor['matcher']['output'] || acceptor['matcher']['inputOutput'])
-                matcher['path'] = Util::Underscore.underscore_jmespath(matcher['path'])
-              end
-            end
+            acceptors.each { |acceptor| preprocess_acceptor(acceptor) }
 
             Util::HashFormatter.new(
               wrap: false,
@@ -64,6 +60,14 @@ def formatted_acceptors(acceptors)
               indent: '            '
             ).format(acceptors: acceptors)
           end
+
+          def preprocess_acceptor(acceptor)
+            if (matcher = acceptor['matcher']['output'] || acceptor['matcher']['inputOutput'])
+              matcher['path'] = Util::Underscore.underscore_jmespath(matcher['path'])
+            elsif (error_type = acceptor['matcher']['errorType'])
+              acceptor['matcher']['errorType'] = error_type.split('#').last.split('#').first
+            end
+          end
         end
       end
     end