Clean document specs

Author: jterapin

gems/smithy-schema/lib/smithy-schema/document_utils.rb

@@ -105,15 +105,15 @@ def apply_union(data, schema, type)
           return if key.nil?
 
           if (member = member_with_json_name(key, shape))
-            apply_union_member(member.name, shape, type)
+            apply_union_member(member.name, value, shape, type)
           elsif shape.name_by_member_name?(key)
-            apply_union_member(key, shape, type)
+            apply_union_member(key, value, shape, type)
           else
             shape.member_type(:unknown).new(key, value)
           end
         end
 
-        def apply_union_member(key, shape, type)
+        def apply_union_member(key, value, shape, type)
           member_name = shape.name_by_member_name(key)
           type = shape.member_type(member_name) if type.nil?
           type.new(apply(value, shape.member(member_name)))

gems/smithy-schema/spec/smithy-schema/document_spec.rb

@@ -194,7 +194,7 @@ def self.name
                   foo_map: { foo: ['Thing1'], bar: ['Thing2'] },
                   structure: { list: ['AnotherThing'] },
                   union: { union_string: 'hello world' },
-                  timestamp: 1_735_084_800,
+                  timestamp: '2024-12-25T00:00:00Z',
                   blob: 'foo'
                 }
               )
@@ -205,13 +205,6 @@ def self.name
               expect(typed_shape).to be_a(simple_runtime)
               expect(typed_shape[:string]).to eq('foo')
             end
-
-            it 'converts document with jsonName trait as a runtime shape' do
-              typed_shape = runtime.new(string: 'foo', union: { union_string: 'bar' })
-              doc = Document.new(typed_shape, schema: schema, use_json_name: true).as_typed(schema)
-              expect(doc.string).to eq('foo')
-              expect(doc.union.value).to eq('bar')
-            end
           end
         end