Fix rbs and PR feedback

Author: Matt Muller

gems/smithy-client/lib/smithy-client/auth.rb

@@ -2,10 +2,11 @@
 
 module Smithy
   module Client
+    # The result of resolving the authentication scheme for a request.
+    ResolvedAuth = Struct.new(:scheme_id, :signer, :signer_properties, :identity_provider, keyword_init: true)
+
     # @api private
     module Auth
-      ResolvedAuth = Struct.new(:scheme_id, :signer, :signer_properties, :identity_provider, keyword_init: true)
-
       class << self
         def resolve(context, endpoint_properties = {})
           if endpoint_properties.key?('authSchemes')
@@ -62,7 +63,7 @@ def prioritize_auth_options(auth_options, auth_scheme_preference)
           preferred_options.empty? ? auth_options : preferred_options
         end
 
-        def resolve_auth_scheme(auth_schemes, auth_options)
+        def resolve_auth_scheme(auth_schemes, auth_options) # rubocop:disable Metrics/MethodLength
           raise 'No auth options were resolved' if auth_options.empty?
 
           failures = []

gems/smithy-client/lib/smithy-client/plugins/resolve_auth.rb

@@ -17,7 +17,10 @@ class ResolveAuth < Plugin
           :auth_scheme_preference,
           doc_type: 'Array<String>',
           rbs_type: 'Array[String]',
-          docstring: 'A list of preferred authentication schemes to use when making a request.'
+          docstring: <<~DOCS
+            An ordered list of preferred authentication schemes to use when making a request.
+            The items in the list must be a fully qualified scheme IDs, such as `smithy.api#httpBearerAuth`.
+          DOCS
         ) do
           []
         end

gems/smithy-client/sig/smithy-client/handler_context.rbs

@@ -9,7 +9,7 @@ module Smithy
       attr_accessor config: Struct[untyped]?
       attr_accessor http_request: Http::Request | untyped
       attr_accessor http_response: Http::Response | untyped
-      attr_accessor auth: AuthScheme
+      attr_accessor auth: ResolvedAuth
       attr_accessor retries: Integer
       attr_reader metadata: Hash[untyped, untyped]
       def []: (untyped) -> untyped

…client/sig/smithy-client/auth_scheme.rbs …ient/sig/smithy-client/resolved_auth.rbsgems/smithy-client/sig/smithy-client/auth_scheme.rbs renamed to gems/smithy-client/sig/smithy-client/resolved_auth.rbs gems/smithy-client/sig/smithy-client/auth_scheme.rbs renamed to gems/smithy-client/sig/smithy-client/resolved_auth.rbs

@@ -1,10 +1,11 @@
 module Smithy
   module Client
-    class AuthScheme
+    class ResolvedAuth
       def initialize: (?Hash[Symbol, untyped] options) -> void
       attr_reader identity_provider: IdentityProvider?
       attr_reader scheme_id: String
       attr_reader signer: _Signer
+      attr_reader signer_properties: Hash[String, String]
     end
   end
 end

gems/smithy-client/spec/smithy-client/plugins/resolve_auth_spec.rb

@@ -38,31 +38,31 @@ module Plugins
 
         it 'supports anonymous auth' do
           resp = client.operation
-          expect(resp.context.auth).to be_a(Auth::ResolvedAuth)
+          expect(resp.context.auth).to be_a(ResolvedAuth)
           expect(resp.context.auth.scheme_id).to eq('smithy.api#noAuth')
         end
 
         it 'supports http api key auth' do
           shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpApiKeyAuth'] = {}
           client_class.add_plugin(HttpApiKeyAuth)
           resp = client.operation
-          expect(resp.context.auth).to be_a(Auth::ResolvedAuth)
+          expect(resp.context.auth).to be_a(ResolvedAuth)
           expect(resp.context.auth.scheme_id).to eq('smithy.api#httpApiKeyAuth')
         end
 
         it 'supports http basic auth' do
           shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpBasicAuth'] = {}
           client_class.add_plugin(HttpBasicAuth)
           resp = client.operation
-          expect(resp.context.auth).to be_a(Auth::ResolvedAuth)
+          expect(resp.context.auth).to be_a(ResolvedAuth)
           expect(resp.context.auth.scheme_id).to eq('smithy.api#httpBasicAuth')
         end
 
         it 'supports http bearer auth' do
           shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpBearerAuth'] = {}
           client_class.add_plugin(HttpBearerAuth)
           resp = client.operation
-          expect(resp.context.auth).to be_a(Auth::ResolvedAuth)
+          expect(resp.context.auth).to be_a(ResolvedAuth)
           expect(resp.context.auth.scheme_id).to eq('smithy.api#httpBearerAuth')
         end