Add identity check in resolve auth

Author: richardwang1124

gems/smithy-client/lib/smithy-client/plugins/resolve_auth.rb

@@ -51,6 +51,11 @@ def resolve_auth(context, auth_options)
                 next
               end
 
+              unless identity_provider.identity
+                failures << "Auth scheme #{scheme_id} failed to resolve identity"
+                next
+              end
+
               return auth_option
             end
 

gems/smithy-client/spec/smithy-client/plugins/resolve_auth_spec.rb

@@ -92,6 +92,15 @@ def resolve(_)
           client = client_class.new(stub_responses: true, api_key_provider: nil)
           expect { client.operation }.to raise_error(/did not have an identity provider configured/)
         end
+
+        it 'raises an error when identity resolver fails to resolve identity' do
+          shapes['smithy.ruby.tests#SampleClient']['traits']['smithy.api#httpApiKeyAuth'] = {}
+          client_class.add_plugin(HttpApiKeyAuth)
+          provider = ApiKeyProvider.new(key: 'stubbed_key')
+          expect(provider).to receive(:identity).and_return(nil)
+          client = client_class.new(stub_responses: true, api_key_provider: provider)
+          expect { client.operation }.to raise_error(/failed to resolve identity/)
+        end
       end
     end
   end

projections/shapes/lib/shapes/auth_resolver.rb

@@ -6,10 +6,10 @@ module ShapeService
   # Resolves the auth scheme from {AuthParameters}.
   class AuthResolver
     # @param [AuthParameters] parameters
-    # @return [String]
+    # @return [Hash]
     def resolve(parameters)
       options = []
-      options << 'smithy.api#noAuth'
+      options << { scheme_id: 'smithy.api#noAuth' }
       options
     end
   end

projections/shapes/shapes.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.files       = Dir['VERSION', 'CHANGELOG.md', 'lib/**/*.rb', base: __dir__]
   spec.license     = 'Apache-2.0'
 
-  spec.add_dependency('smithy-client', '~> 1')
+  spec.add_dependency('smithy-client', '1.0.0.pre1')
 
   spec.required_ruby_version = '>= 3.3'
 end

projections/weather/lib/weather/auth_resolver.rb

@@ -6,10 +6,10 @@ module Weather
   # Resolves the auth scheme from {AuthParameters}.
   class AuthResolver
     # @param [AuthParameters] parameters
-    # @return [String]
+    # @return [Hash]
     def resolve(parameters)
       options = []
-      options << 'smithy.api#noAuth'
+      options << { scheme_id: 'smithy.api#noAuth' }
       options
     end
   end

projections/weather/weather.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.files       = Dir['VERSION', 'CHANGELOG.md', 'lib/**/*.rb', base: __dir__]
   spec.license     = 'Apache-2.0'
 
-  spec.add_dependency('smithy-client', '~> 1')
+  spec.add_dependency('smithy-client', '1.0.0.pre1')
 
   spec.required_ruby_version = '>= 3.3'
 end