Add lots of scoping and spi (#1035)

Author: dayaffe

Sources/ClientRuntime/Networking/Http/CRT/CRTClientEngine.swift

@@ -11,15 +11,16 @@ import protocol Smithy.LogAgent
 import enum Smithy.StreamError
 import struct Smithy.SwiftLogger
 import enum Smithy.URIScheme
-import class SmithyChecksums.ChunkedStream
+@_spi(SmithyChecksums) import class SmithyChecksums.ChunkedStream
 import enum SmithyHTTPAPI.ALPNProtocol
 import struct SmithyHTTPAPI.Endpoint
 import struct SmithyHTTPAPI.Headers
 import protocol SmithyHTTPAPI.HTTPClient
 import class SmithyHTTPAPI.HTTPRequest
 import class SmithyHTTPAPI.HTTPResponse
 import enum SmithyHTTPAPI.HTTPStatusCode
-import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
+@_spi(SmithyHTTPClient) import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
+@_spi(SmithyHTTPClient) import SmithyHTTPClient
 import class SmithyHTTPClientAPI.HttpTelemetry
 import class SmithyStreams.BufferedStream
 import SmithyTelemetryAPI

Sources/ClientRuntime/Networking/Http/CRT/HTTP2Stream+ByteStream.swift

@@ -8,7 +8,7 @@
 import AwsCommonRuntimeKit
 import struct Smithy.Attributes
 import enum Smithy.ByteStream
-import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
+@_spi(SmithyHTTPClient) import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
 import class SmithyHTTPClientAPI.HttpTelemetry
 
 extension HTTP2Stream {

Sources/ClientRuntime/Networking/Http/Middlewares/AuthSchemeMiddleware.swift

@@ -10,7 +10,7 @@ import struct Smithy.Attributes
 import enum Smithy.ClientError
 import class Smithy.Context
 import class SmithyHTTPAPI.HTTPRequestBuilder
-import struct SmithyHTTPAuth.DefaultIdentityResolverConfiguration
+@_spi(SmithyHTTPAuth) import struct SmithyHTTPAuth.DefaultIdentityResolverConfiguration
 import protocol SmithyHTTPAuthAPI.AuthScheme
 import struct SmithyHTTPAuthAPI.SelectedAuthScheme
 

Sources/ClientRuntime/Networking/Http/Middlewares/RequestBody/EventStreamBodyMiddleware.swift

@@ -8,7 +8,7 @@
 import struct Foundation.Data
 import class Smithy.Context
 import protocol Smithy.RequestMessageSerializer
-import SmithyEventStreams
+@_spi(SmithyEventStreams) import SmithyEventStreams
 import SmithyEventStreamsAPI
 import SmithyEventStreamsAuthAPI
 import SmithyHTTPAPI

Sources/ClientRuntime/Networking/Http/URLSession/FoundationStreamBridge.swift

@@ -22,7 +22,7 @@ import class Foundation.Timer
 import struct Smithy.Attributes
 import protocol Smithy.LogAgent
 import protocol Smithy.ReadableStream
-import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
+@_spi(SmithyHTTPClient) import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
 import class SmithyHTTPClientAPI.HttpTelemetry
 
 /// Reads data from a smithy-swift native `ReadableStream` and streams the data through to a Foundation `InputStream`.

Sources/ClientRuntime/Networking/Http/URLSession/URLSessionHTTPClient.swift

@@ -41,7 +41,8 @@ import protocol SmithyHTTPAPI.HTTPClient
 import class SmithyHTTPAPI.HTTPRequest
 import class SmithyHTTPAPI.HTTPResponse
 import enum SmithyHTTPAPI.HTTPStatusCode
-import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
+@_spi(SmithyHTTPClient) import enum SmithyHTTPClientAPI.HttpMetricsAttributesKeys
+@_spi(SmithyHTTPClient) import SmithyHTTPClient
 import class SmithyHTTPClientAPI.HttpTelemetry
 import class SmithyStreams.BufferedStream
 import SmithyTelemetryAPI

Sources/ClientRuntime/Networking/Streaming/ByteStream+Validating.swift

@@ -7,7 +7,7 @@
 
 import enum Smithy.ByteStream
 import protocol Smithy.Stream
-import class SmithyChecksums.ValidatingBufferedStream
+@_spi(SmithyChecksums) import class SmithyChecksums.ValidatingBufferedStream
 import enum SmithyChecksumsAPI.ChecksumAlgorithm
 import class SmithyStreams.BufferedStream
 

Sources/Smithy/ByteStream.swift

@@ -74,7 +74,7 @@ extension ByteStream: CustomDebugStringConvertible {
 }
 
 public enum ByteStreamError: Error, Sendable {
-    case streamNotSeeakble
+    case streamNotSeekable
     case invalidStreamTypeForChunkedBody(String)
     case streamClosedOrEmpty
     case streamDoesNotConformToChunkedStream(String)

Sources/Smithy/Context.swift

@@ -85,5 +85,5 @@ public class ContextBuilder {
 }
 
 enum AttributeKeys {
-    public static let logger = AttributeKey<LogAgent>(name: "Logger")
+    static let logger = AttributeKey<LogAgent>(name: "Logger")
 }

Sources/Smithy/URI.swift

@@ -232,7 +232,7 @@ extension String {
         return decoded != nil && decoded != self
     }
 
-    public func percentEncodePathIncludingSemicolon() -> String {
+    func percentEncodePathIncludingSemicolon() -> String {
         let allowed =
         // swiftlint:disable force_cast
             (CharacterSet.urlPathAllowed as NSCharacterSet).mutableCopy() as! NSMutableCharacterSet
@@ -241,32 +241,32 @@ extension String {
         return self.addingPercentEncoding(withAllowedCharacters: allowed as CharacterSet)!
     }
 
-    public func percentEncodeQuery() -> String {
+    func percentEncodeQuery() -> String {
         return self.addingPercentEncoding(withAllowedCharacters: CharacterSet.urlQueryAllowed as CharacterSet)!
     }
 }
 
 extension Array where Element == URIQueryItem {
-    public var queryString: String? {
+    var queryString: String? {
         if self.isEmpty {
             return nil
         }
         return self.map { [$0.name, $0.value].compactMap { $0 }.joined(separator: "=") }.joined(separator: "&")
     }
 
-    public func toURLQueryItems() -> [URLQueryItem] {
+    func toURLQueryItems() -> [URLQueryItem] {
         return self.map { URLQueryItem(name: $0.name, value: $0.value) }
     }
 
-    public func containsPercentEncode() -> Bool {
+    func containsPercentEncode() -> Bool {
         return self.contains { item in
             return item.name.isPercentEncoded || (item.value?.isPercentEncoded ?? false)
         }
     }
 }
 
 extension Array where Element == URLQueryItem {
-    public func containsPercentEncode() -> Bool {
+    func containsPercentEncode() -> Bool {
         return self.contains { item in
             return item.name.isPercentEncoded || (item.value?.isPercentEncoded ?? false)
         }