Skip to content

Commit abb68ab

Browse files
sichanyooSichan Yoo
and
Sichan Yoo
authored
fix: Make default HTTP client provider use the customer-provided config if present (#914)
Co-authored-by: Sichan Yoo <[email protected]>
1 parent 6882dab commit abb68ab

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Diff for: Sources/ClientRuntime/Config/ClientConfigDefaultsProvider.swift

+4-2
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,11 @@ public typealias RuntimeConfigType
1717

1818
open class ClientConfigDefaultsProvider {
1919
/// Returns a default `HTTPClient` engine.
20-
open class func httpClientEngine() -> HTTPClient {
20+
open class func httpClientEngine(
21+
_ config: HttpClientConfiguration? = nil
22+
) -> HTTPClient {
2123
return RuntimeConfigType.makeClient(
22-
httpClientConfiguration: RuntimeConfigType.defaultHttpClientConfiguration
24+
httpClientConfiguration: config ?? RuntimeConfigType.defaultHttpClientConfiguration
2325
)
2426
}
2527

Diff for: Sources/ClientRuntime/Config/DefaultSDKRuntimeConfiguration.swift

+3-3
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,9 @@ public extension DefaultSDKRuntimeConfiguration {
9898
let socketTimeout = UInt32(httpClientConfiguration.socketTimeout)
9999
let config = CRTClientEngineConfig(
100100
telemetry: httpClientConfiguration.telemetry ?? CRTClientEngine.noOpCrtClientEngineTelemetry,
101-
connectTimeoutMs: connectTimeoutMs,
102-
crtTlsOptions: httpClientConfiguration.tlsConfiguration as? CRTClientTLSOptions,
103-
socketTimeout: socketTimeout
101+
connectTimeoutMs: connectTimeoutMs,
102+
crtTlsOptions: httpClientConfiguration.tlsConfiguration as? CRTClientTLSOptions,
103+
socketTimeout: socketTimeout
104104
)
105105
return CRTClientEngine(config: config)
106106
#endif

0 commit comments

Comments
 (0)