chore: use guarded for-in

Author: kuhe

.changeset/nasty-walls-tap.md

@@ -0,0 +1,8 @@
+---
+"@smithy/undici-http-handler": patch
+"@smithy/node-http-handler": patch
+"@smithy/server-common": patch
+"@smithy/core": patch
+---
+
+switch for-in loops to guarded

.oxlintrc.json

@@ -10,6 +10,7 @@
   "rules": {
     "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/no-import-type-side-effects": "error",
+    "guard-for-in": "error",
     "no-sparse-arrays": "off",
     "no-unused-vars": ["error", { "args": "none", "caughtErrorsIgnorePattern": "^ignored", "varsIgnorePattern": "^_" }],
     "unicorn/no-new-array": "off",

packages/core/src/legacy-root-exports/util-identity-and-auth/DefaultIdentityProviderConfig.ts

@@ -13,7 +13,7 @@ export class DefaultIdentityProviderConfig implements IdentityProviderConfig {
    * @param config scheme IDs and identity providers to configure
    */
   constructor(config: Record<HttpAuthSchemeId, IdentityProvider<Identity> | undefined>) {
-    for (const key in config) {
+    for (const key of Object.keys(config)) {
       const value = config[key];
       if (value !== undefined) {
         this.authSchemes.set(key, value);

packages/core/src/submodules/cbor/codec-v1/CborShapeDeserializer.ts

@@ -79,7 +79,7 @@ export class CborShapeDeserializer extends SerdeContext implements ShapeDeserial
       if (ns.isMapSchema()) {
         const targetSchema = ns.getValueSchema();
 
-        for (const key in value) {
+        for (const key of Object.keys(value)) {
           const itemValue = this.readValue(targetSchema, value[key]);
           newObject[key] = itemValue;
         }
@@ -88,7 +88,7 @@ export class CborShapeDeserializer extends SerdeContext implements ShapeDeserial
         let keys: Set<string> | undefined;
         if (isUnion) {
           keys = new Set<string>();
-          for (const k in value) {
+          for (const k of Object.keys(value)) {
             if (k !== "__type") {
               keys.add(k);
             }
@@ -104,7 +104,7 @@ export class CborShapeDeserializer extends SerdeContext implements ShapeDeserial
         }
         if (isUnion && keys?.size === 1) {
           let newObjectEmpty = true;
-          for (const _ in newObject) {
+          for (const _ of Object.keys(newObject)) {
             newObjectEmpty = false;
             break;
           }
@@ -115,7 +115,7 @@ export class CborShapeDeserializer extends SerdeContext implements ShapeDeserial
         } else if (typeof value.__type === "string") {
           // This if-block is for backwards compatibility support and should not be copied
           // to other implementations.
-          for (const k in value) {
+          for (const k of Object.keys(value)) {
             if (!(k in newObject)) {
               // we have no type information, so copy as-is from CBOR-derived object.
               newObject[k] = value[k];

packages/core/src/submodules/cbor/codec-v1/CborShapeSerializer.ts

@@ -65,7 +65,7 @@ export class CborShapeSerializer extends SerdeContext implements ShapeSerializer
       const newObject = {} as any;
       if (ns.isMapSchema()) {
         const sparse = !!ns.getMergedTraits().sparse;
-        for (const key in sourceObject) {
+        for (const key of Object.keys(sourceObject)) {
           const value = this.serialize(ns.getValueSchema(), sourceObject[key]);
           if (value != null || sparse) {
             newObject[key] = value;
@@ -85,7 +85,7 @@ export class CborShapeSerializer extends SerdeContext implements ShapeSerializer
         } else if (typeof sourceObject.__type === "string") {
           // This if-block is for backwards compatibility support and should not be copied
           // to other implementations.
-          for (const k in sourceObject) {
+          for (const k of Object.keys(sourceObject)) {
             if (!(k in newObject)) {
               // we have no type information, so serialize with Document rules.
               newObject[k] = this.serialize(15 satisfies DocumentSchema, sourceObject[k]);
@@ -101,7 +101,7 @@ export class CborShapeSerializer extends SerdeContext implements ShapeSerializer
           }
           return newArray;
         }
-        for (const key in sourceObject) {
+        for (const key of Object.keys(sourceObject)) {
           newObject[key] = this.serialize(ns.getValueSchema(), sourceObject[key]);
         }
       } else if (ns.isBigDecimalSchema()) {

packages/core/src/submodules/cbor/codec-v2/CborShapeDeserializer2.ts

@@ -172,7 +172,7 @@ function readStruct(ns: NormalizedSchema, count: number, startPos: number): any
 
   if (isUnion) {
     let resultEmpty = true;
-    for (const _ in result) {
+    for (const _ of Object.keys(result)) {
       resultEmpty = false;
       break;
     }
@@ -347,7 +347,7 @@ function readMapIndefinite(ns: NormalizedSchema): any {
         pos += 1;
         if (isUnion) {
           let resultEmpty = true;
-          for (const _ in result) {
+          for (const _ of Object.keys(result)) {
             resultEmpty = false;
             break;
           }
@@ -693,15 +693,15 @@ function transformObject(ns: NormalizedSchema, value: any): any {
 
   if (ns.isMapSchema()) {
     const targetSchema = ns.getValueSchema();
-    for (const key in value) {
+    for (const key of Object.keys(value)) {
       newObject[key] = transformObject(targetSchema, value[key]);
     }
   } else if (ns.isStructSchema()) {
     const isUnion = ns.isUnionSchema();
     let keys: Set<string> | undefined;
     if (isUnion) {
       keys = new Set<string>();
-      for (const k in value) {
+      for (const k of Object.keys(value)) {
         if (k !== "__type") {
           keys.add(k);
         }
@@ -717,7 +717,7 @@ function transformObject(ns: NormalizedSchema, value: any): any {
     }
     if (isUnion && keys?.size === 1) {
       let newObjectEmpty = true;
-      for (const _ in newObject) {
+      for (const _ of Object.keys(newObject)) {
         newObjectEmpty = false;
         break;
       }
@@ -726,7 +726,7 @@ function transformObject(ns: NormalizedSchema, value: any): any {
         newObject.$unknown = [k, value[k]];
       }
     } else if (typeof value.__type === "string") {
-      for (const k in value) {
+      for (const k of Object.keys(value)) {
         if (!(k in newObject)) {
           newObject[k] = value[k];
         }

packages/core/src/submodules/cbor/codec-v2/CborShapeSerializer2.ts

@@ -352,7 +352,7 @@ function writeStruct(ns: NormalizedSchema, value: Record<string, unknown>, serde
   }
 
   if (typeof value.__type === "string") {
-    for (const k in value) {
+    for (const k of Object.keys(value)) {
       if (!memberNames.includes(k)) {
         writeString(k);
         writeUntypedValue(value[k]);
@@ -418,7 +418,7 @@ function writeMap(ns: NormalizedSchema, value: Record<string, unknown>, isDocume
   const valueSchema = ns.getValueSchema();
 
   const keys: string[] = [];
-  for (const k in value) {
+  for (const k of Object.keys(value)) {
     const v = value[k];
     if (isDocument ? v !== undefined : v != null || sparse) {
       keys.push(k);

packages/core/src/submodules/cbor/parseCborBody.ts

@@ -74,7 +74,7 @@ export const loadSmithyRpcV2CborErrorCode = (output: HttpResponse, data: any): s
   }
 
   let codeKey: string | undefined;
-  for (const key in data) {
+  for (const key of Object.keys(data)) {
     if (key.toLowerCase() === "code") {
       codeKey = key;
       break;
@@ -121,7 +121,7 @@ export const buildHttpRpcRequest = async (
     contents.hostname = resolvedHostname;
   }
   if (endpoint.headers) {
-    for (const name in endpoint.headers) {
+    for (const name of Object.keys(endpoint.headers)) {
       contents.headers[name] = endpoint.headers[name];
     }
   }

packages/core/src/submodules/client/hasOwn.ts

@@ -0,0 +1,6 @@
+/**
+ * @internal
+ */
+export function hasOwn(o: object, k: string) {
+  return Object.prototype.hasOwnProperty.call(o, k);
+}

packages/core/src/submodules/client/smithy-client/extensions/checksum.ts

@@ -32,7 +32,7 @@ export type PartialChecksumRuntimeConfigType = {
 export const getChecksumConfiguration = (runtimeConfig: PartialChecksumRuntimeConfigType) => {
   const checksumAlgorithms: ChecksumAlgorithm[] = [];
 
-  for (const id in AlgorithmId) {
+  for (const id of Object.keys(AlgorithmId)) {
     const algorithmId = AlgorithmId[id as keyof typeof AlgorithmId];
     if (runtimeConfig[algorithmId] === undefined) {
       continue;