Raise the severity for query error validator to danger (#2758)

Author: sugmanue

smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/protocols/QueryErrorCodeValidator.java

@@ -23,7 +23,7 @@
 import software.amazon.smithy.utils.SmithyInternalApi;
 
 /**
- * Emits a warning if two or more error shapes share the same error code.
+ * Emits a danger if two or more error shapes share the same error code.
  */
 @SmithyInternalApi
 public class QueryErrorCodeValidator extends AbstractValidator {
@@ -73,7 +73,7 @@ private List<ValidationEvent> validateService(Model model, ServiceShape service)
             if (events.isEmpty()) {
                 events = new ArrayList<>();
             }
-            events.add(warning(service,
+            events.add(danger(service,
                     String.format("Multiple error shapes with the error code `%s` found: [%s]. This error code "
                             + "ambiguity will result in the wrong error shape being deserialized when running the "
                             + "query protocol. This pain will be carried forward when migrating to a new protocol "

smithy-aws-traits/src/test/resources/software/amazon/smithy/aws/traits/errorfiles/protocols/query-errors-must-be-unique.errors

@@ -1,2 +1,2 @@
-[WARNING] smithy.example#QueryCompatibleService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode
-[WARNING] smithy.example#QueryService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode
+[DANGER] smithy.example#QueryCompatibleService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode
+[DANGER] smithy.example#QueryService: Multiple error shapes with the error code `ResourceNotFound` found: [smithy.example#DocumentNotFound, smithy.example#ResourceNotFound]. This error code ambiguity will result in the wrong error shape being deserialized when running the query protocol. This pain will be carried forward when migrating to a new protocol when using the awsQueryCompatible trait. | QueryErrorCode