Skip to content

[Bug] [or feature?] ROI boundary conditions. #1090

@christakahashi

Description

@christakahashi

System

UVtools v5.2.1 X64
Operative system: Microsoft Windows 10.0.22631 X64
Processor: 12th Gen Intel(R) Core(TM) i5-12600K
Processor cores: 16
Memory RAM: 36.54 / 63.78 GB
Runtime: win-x64
Framework: .NET 9.0.9
AvaloniaUI: 11.3.6
OpenCV: 4.11.0

Sreens, resolution, working area, usable area:
1: 2560 x 1440 @ 100% (Primary) (On this)
    WA: 2560 x 1392    UA: 2560 x 1392
2: 1080 x 1920 @ 100%
    WA: 1080 x 1872    UA: 1080 x 1872

Path:       C:\Program Files\UVtools\
Executable: C:\Program Files\UVtools\UVtools.exe
Loaded file: foo.goo [Version: 0] [Class: GooFile]

Printer and Slicer

  • Printer: mars 4 ultra
  • Slicer: lychee

Description of the bug

The morph operation has unnecessarily rough boundaries when used with ROI. It would be preferable to expand the ROI by the kernel size (times the number of iterations) before running the operation and then cropping it down to the original ROI after that way the operation has context for the content near the boundary even if its only applying changes to the ROI.

e.g. when doing the close operation you get this jagged edge (and sometimes an island) in the current version

Image

How to reproduce

apply close operation with ROI that cuts the edge off of a region.

Files

No response

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions