apps.mellanox.connectx: overhaul async execution of firmware commands #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mechanism for executing commands in an asynchronous manner imposes an artificial limit to the number of RSS queues that can be configured. This is due to assigning a fixed slot in the command queue to each asynchronous command, capping the effective number of RSS queues by the size of the command queue because each queue requires one command to periodically read its statistics counters. This commit introduces a new object CMDQ that schedules an arbitrary number of commands to the fixed-size physical command queue to overcome the limitation. It replaces the HCA_factory and enforces a better coding style for asynchronous commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism for executing commands in an asynchronous manner imposes an artificial limit to the number of RSS queues that can be configured. This is due to assigning a fixed slot in the command queue to each asynchronous command, capping the effective number of RSS queues by the size of the command queue because each queue requires one command to periodically read its statistics counters.
This commit introduces a new object CMDQ that schedules an arbitrary number of commands to the fixed-size physical command queue to overcome the limitation. It replaces the HCA_factory and enforces a better coding style for asynchronous commands.