Fix warnings

Author: snailspeed3

source/c-discord-rich-presence/include/discord_rpc.h

@@ -24,7 +24,8 @@ struct Activity {
   Assets assets;
   struct Button {
     std::string text = "A button";
-    std::string link = "https://github.com/riidefi/RiiStudio/tree/master/source/c-discord-rich-presence";
+    std::string link = "https://github.com/riidefi/RiiStudio/tree/master/"
+                       "source/c-discord-rich-presence";
   };
   std::vector<Button> buttons{Button{}};
 };
@@ -84,29 +85,39 @@ void rsl_rpc_test(struct C_RPC*);
 
 #ifdef __cplusplus
 namespace discord_rpc {
+
+static inline char* my_strdup(const char* in) {
+  auto len = strlen(in);
+  char* buf = (char*)malloc(len + 1);
+  memcpy(buf, in, len);
+  buf[len] = '\0';
+  return buf;
+}
+
 // Functions to create and destroy the Activity_C struct and to access the
 // fields of the Activity struct
-inline Activity_C* create_activity(const Activity& activity) {
+static inline Activity_C* create_activity(const Activity& activity) {
   Activity_C* activity_c = new Activity_C;
 
   // Allocate and copy strings for state and details
-  activity_c->state = strdup(activity.state.c_str());
-  activity_c->details = strdup(activity.details.c_str());
+  activity_c->state = my_strdup(activity.state.c_str());
+  activity_c->details = my_strdup(activity.details.c_str());
 
   // Copy timestamps and assets
   activity_c->timestamps.start = activity.timestamps.start;
   activity_c->timestamps.end = activity.timestamps.end;
-  activity_c->assets.large_image = strdup(activity.assets.large_image.c_str());
-  activity_c->assets.large_text = strdup(activity.assets.large_text.c_str());
+  activity_c->assets.large_image =
+      my_strdup(activity.assets.large_image.c_str());
+  activity_c->assets.large_text = my_strdup(activity.assets.large_text.c_str());
 
   // Allocate and copy button vector
   activity_c->buttons.length = activity.buttons.size();
   activity_c->buttons.buttons = new Button_C[activity_c->buttons.length];
   for (size_t i = 0; i < activity_c->buttons.length; i++) {
     activity_c->buttons.buttons[i].text =
-        strdup(activity.buttons[i].text.c_str());
+        my_strdup(activity.buttons[i].text.c_str());
     activity_c->buttons.buttons[i].link =
-        strdup(activity.buttons[i].link.c_str());
+        my_strdup(activity.buttons[i].link.c_str());
   }
 
   return activity_c;

source/frontend/legacy_editor/views/PropertyEditor.cpp

@@ -52,7 +52,7 @@ class PropertyEditor : public StudioWindow, private PropertyEditorWidget {
                  std::function<kpi::IObject*()> selectionActive,
                  auto drawImageIcon)
       : StudioWindow("Property Editor"), drawImageIcon(drawImageIcon),
-        mHost(host), mSelectionActive(selectionActive), mRoot(root),
+        mHost(host), mRoot(root), mSelectionActive(selectionActive),
         mSelection(selection) {
     setWindowFlag(ImGuiWindowFlags_MenuBar);
     setClosable(false);
@@ -141,8 +141,7 @@ template <typename T> void PropertyEditor<T>::draw_() {
     ImGui::SameLine();
     if (ImGui::Button((const char*)ICON_FA_LINK " Force recompile")) {
       for (auto& o : mSelection()) {
-        if (lib3d::Material* m =
-                dynamic_cast<lib3d::Material*>(mSelectionActive())) {
+        if (lib3d::Material* m = dynamic_cast<lib3d::Material*>(o)) {
           m->nextGenerationId();
         }
       }

source/frontend/level_editor/ViewCube.cpp

@@ -33,7 +33,7 @@ bool DrawViewCube(float last_width, float last_height, glm::mat4& view_mtx,
 
   for (int i = 0; i < 4; ++i) {
     for (int j = 0; j < 4; ++j) {
-      auto& f = view_mtx[i][j];
+      [[maybe_unused]] auto& f = view_mtx[i][j];
       assert(!std::isnan(f));
     }
   }

source/librii/crate/g3d_crate.cpp

@@ -99,8 +99,8 @@ Result<g3d::G3dShader> ReadMDL0Shade(std::span<const u8> file) {
   // So the DL parser doesn't discard IndOrders
   gx_mat.indirectStages.resize(4);
   // Trust the stage count since we have not necessarily read the material yet.
-  g3d::ReadTev(gx_mat, reader, /* tev_addr */ 0,
-               /* trust_stagecount */ true, /* brawlbox_bug */ true);
+  TRY(g3d::ReadTev(gx_mat, reader, /* tev_addr */ 0,
+                   /* trust_stagecount */ true, /* brawlbox_bug */ true));
 
   g3d::G3dShader shader;
 

source/librii/szs/CTGP.cpp

@@ -570,7 +570,7 @@ bool Yaz_open(Yaz_file_struct* file, WRITE_FN fptr) {
       0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
   };
 
-  int ret = file->file_write(szsHeader, sizeof(szsHeader), 1);
+  [[maybe_unused]] int ret = file->file_write(szsHeader, sizeof(szsHeader), 1);
   assert(ret == 1);
 
   file->copyLocation = -1;

source/plugins/rhst/RHSTImporter.cpp

@@ -49,6 +49,7 @@ void compileAlphaMode(librii::gx::LowLevelGxMaterial& mat,
                       librii::rhst::AlphaMode alpha_mode) {
   librii::hx::PixMode pix_mode = librii::hx::PIX_DEFAULT_OPAQUE;
   switch (alpha_mode) {
+  case librii::rhst::AlphaMode::Custom:
   case librii::rhst::AlphaMode::Opaque:
     pix_mode = librii::hx::PIX_DEFAULT_OPAQUE;
     break;