Skip to content

Commit 7c8e6b8

Browse files
committed
[Apple] Fix build
We weren't explicitly including `bzip` for RSL, so the `wbz` crate was actually covering our missing dep on MacOS (via the `bz2` crate). So when we switched to the Rust version of `bz2`, we no longer had the duplicate dependency, hence the build broke. Now, we update `zip` and fix a similar bug with `liblzma` (XZ). (New `zip` dep?) Might need to adjust this on Linux, too. (These CMake scripts should be refactored considerably)
1 parent 4c65450 commit 7c8e6b8

File tree

7 files changed

+849
-254
lines changed

7 files changed

+849
-254
lines changed

.github/workflows/cmake.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ jobs:
139139
- name: CMake -- configure
140140
shell: bash
141141
working-directory: ${{github.workspace}}/build
142-
run: cmake $GITHUB_WORKSPACE -GNinja -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DRust_CARGO_TARGET=aarch64-apple-darwin -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=/opt/homebrew/Cellar/llvm/20.1.6/bin/clang++
142+
run: cmake $GITHUB_WORKSPACE -GNinja -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DRust_CARGO_TARGET=aarch64-apple-darwin -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=/opt/homebrew/Cellar/llvm/20.1.8/bin/clang++
143143

144144
- name: CMake -- build
145145
working-directory: ${{github.workspace}}/build

source/cli/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,16 @@ elseif (APPLE)
4949

5050
set(GLFW_VERSION "3.4")
5151
set(FREETYPE_VERSION "2.13.3")
52+
set(XZ_VERSION "5.8.1")
5253

53-
SET_TARGET_PROPERTIES(cli PROPERTIES LINK_FLAGS "-framework CoreFoundation -framework Security -framework SystemConfiguration -ldl ${HOMEBREW_CELLAR}/glfw/${GLFW_VERSION}/lib/libglfw.dylib ${HOMEBREW_CELLAR}/freetype/${FREETYPE_VERSION}/lib/libfreetype.dylib")
54+
SET_TARGET_PROPERTIES(cli PROPERTIES LINK_FLAGS "-framework CoreFoundation -framework Security -framework SystemConfiguration -ldl ${HOMEBREW_CELLAR}/glfw/${GLFW_VERSION}/lib/libglfw.dylib ${HOMEBREW_CELLAR}/freetype/${FREETYPE_VERSION}/lib/libfreetype.dylib ${HOMEBREW_CELLAR}/xz/${XZ_VERSION}/lib/liblzma.a")
5455
elseif (UNIX AND NOT EMSCRIPTEN)
5556
find_library(GLFW3_LIBRARY NAMES libglfw.so PATHS /usr/lib)
5657
find_library(FREETYPE_LIBRARY NAMES libfreetype.so PATHS /usr/lib)
5758
find_library(BZIP2_LIBRARY NAMES libbz2.so PATHS /usr/lib)
5859
find_library(SSL_LIBRARY NAMES libssl.so PATHS /usr/lib)
5960
find_library(CRYPTO_LIBRARY NAMES libcrypto.so PATHS /usr/lib)
61+
# TODO: May need liblzma on linux now
6062
target_link_libraries(cli PUBLIC
6163
${GLFW3_LIBRARY}
6264
${FREETYPE_LIBRARY}

source/frontend/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,9 @@ if (NOT MSVC)
153153

154154
set(GLFW_VERSION "3.4")
155155
set(FREETYPE_VERSION "2.13.3")
156+
set(XZ_VERSION "5.8.1")
156157

157-
SET_TARGET_PROPERTIES(frontend PROPERTIES LINK_FLAGS "-framework CoreFoundation -framework Security -framework SystemConfiguration -ldl ${HOMEBREW_CELLAR}/glfw/${GLFW_VERSION}/lib/libglfw.dylib ${HOMEBREW_CELLAR}/freetype/${FREETYPE_VERSION}/lib/libfreetype.dylib")
158+
SET_TARGET_PROPERTIES(frontend PROPERTIES LINK_FLAGS "-framework CoreFoundation -framework Security -framework SystemConfiguration -ldl ${HOMEBREW_CELLAR}/glfw/${GLFW_VERSION}/lib/libglfw.dylib ${HOMEBREW_CELLAR}/freetype/${FREETYPE_VERSION}/lib/libfreetype.dylib ${HOMEBREW_CELLAR}/xz/${XZ_VERSION}/lib/liblzma.a")
158159
elseif (UNIX)
159160
# --start-group, --end-group allows circular dependencies among object files
160161
if (EMSCRIPTEN)

source/librii/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ elseif (APPLE)
199199
set(HOMEBREW_CELLAR "/usr/local/Cellar")
200200
endif()
201201

202-
set(ASSIMP_VERSION "6.0.1")
202+
set(ASSIMP_VERSION "6.0.2")
203203
target_link_libraries(librii PUBLIC "${HOMEBREW_CELLAR}/assimp/${ASSIMP_VERSION}/lib/libassimp.dylib")
204204
elseif (EMSCRIPTEN)
205205
target_link_libraries(librii PUBLIC

0 commit comments

Comments
 (0)