Skip to content

Version Check may lead to deadlock of threadings #492

@kssamwang

Description

@kssamwang

In version.py, you start a new thread to check whether it is the latest version.

import os
import logging
from threading import Thread

__version__ = '1.3.6'

try:
    os.environ['OUTDATED_IGNORE'] = '1'
    from outdated import check_outdated  # noqa
except ImportError:
    check_outdated = None


def check():
    try:
        is_outdated, latest = check_outdated('ogb', __version__)
        if is_outdated:
            logging.warning(
                f'The OGB package is out of date. Your version is '
                f'{__version__}, while the latest version is {latest}.')
    except Exception:
        pass


if check_outdated is not None:
    thread = Thread(target=check)
    thread.start()

If some network errors occur in the request of version check , this thread remains alive , when the python program is going to quit , this thread may lead to deadlock in multi-threads.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions