[Enhancement]: s390x support?

[brlin-tw]

What changes would you like?

Hello, is it possible for this snap to support the s390x architecture? We currently have a consumer snap that is previously enabled on this platform and would still like to have it supported.

Is there any technical blockage that prevent this from happening?

Any extra information?

No response

[lucyllewy]

yes, I agree that this is a good idea. Even if none of us use it ourselves, because it is a content snap that we want others to use in their own snaps I think we should get it supported on all architectures we can.

[brlin-tw]

A test build reveals that at least the avisynth-plus part does not support s390x architecture:

:: + cmake --build . -- -j2                                                                                                                                                                                       
:: [  1%] Building C object plugins/Shibatch/CMakeFiles/PluginShibatch.dir/dbesi0.c.o                                                                                                                             
:: -- Found Git: /usr/bin/git (found version "2.43.0")                                                                                                                                                            
:: [  1%] Built target VersionGen                                                                                                                                                                                 
:: [  2%] Building CXX object plugins/ConvertStacked/CMakeFiles/PluginConvertStacked.dir/ConvertStacked.cpp.o                                                                                                     
:: [  3%] Building CXX object plugins/Shibatch/CMakeFiles/PluginShibatch.dir/ssrc.cpp.o                                                                                                                           
:: In file included from /root/parts/avisynth-plus/src/avs_core/include/avisynth.h:96,                                                                                                                            
::                  from /root/parts/avisynth-plus/src/plugins/ConvertStacked/ConvertStacked.cpp:37:                                                                                                              
:: /root/parts/avisynth-plus/src/avs_core/include/avs/config.h:69:5: error: #error Unsupported CPU architecture.                                                                                                  
::    69 | #   error Unsupported CPU architecture.                                                                                                                                                                
::       |     ^~~~~                                                                                                                                                                                              
:: In file included from /root/parts/avisynth-plus/src/avs_core/include/avisynth.h:96,                                                                                                                            
::                  from /root/parts/avisynth-plus/src/plugins/Shibatch/ssrc.h:21,                                                                                                                                
::                  from /root/parts/avisynth-plus/src/plugins/Shibatch/ssrc.cpp:16:                                                                                                                              
:: /root/parts/avisynth-plus/src/avs_core/include/avs/config.h:69:5: error: #error Unsupported CPU architecture.                                                                                                  
::    69 | #   error Unsupported CPU architecture.                                                                                                                                                                
::       |     ^~~~~                                                                                                                                                                                              
:: gmake[2]: *** [plugins/ConvertStacked/CMakeFiles/PluginConvertStacked.dir/build.make:76: plugins/ConvertStacked/CMakeFiles/PluginConvertStacked.dir/ConvertStacked.cpp.o] Error 1                              
:: gmake[1]: *** [CMakeFiles/Makefile2:255: plugins/ConvertStacked/CMakeFiles/PluginConvertStacked.dir/all] Error 2                                                                                               
:: gmake[1]: *** Waiting for unfinished jobs....                                                                                                                                                                  
:: [  4%] Building CXX object plugins/Shibatch/CMakeFiles/PluginShibatch.dir/ssrc-convert.cpp.o                                                                                                                   
:: In file included from /root/parts/avisynth-plus/src/avs_core/include/avisynth.h:96,                                                                                                                            
::                  from /root/parts/avisynth-plus/src/plugins/Shibatch/ssrc-convert.h:40,                                                                                                                        
::                  from /root/parts/avisynth-plus/src/plugins/Shibatch/ssrc-convert.cpp:35:                                                                                                                      
:: /root/parts/avisynth-plus/src/avs_core/include/avs/config.h:69:5: error: #error Unsupported CPU architecture.                                                                                                  
::    69 | #   error Unsupported CPU architecture.                                                                                                                                                                
::       |     ^~~~~                                                                                                                                                                                              
:: gmake[2]: *** [plugins/Shibatch/CMakeFiles/PluginShibatch.dir/build.make:104: plugins/Shibatch/CMakeFiles/PluginShibatch.dir/ssrc-convert.cpp.o] Error 1
:: gmake[2]: *** Waiting for unfinished jobs....
:: gmake[2]: *** [plugins/Shibatch/CMakeFiles/PluginShibatch.dir/build.make:90: plugins/Shibatch/CMakeFiles/PluginShibatch.dir/ssrc.cpp.o] Error 1
:: gmake[1]: *** [CMakeFiles/Makefile2:229: plugins/Shibatch/CMakeFiles/PluginShibatch.dir/all] Error 2
:: gmake: *** [Makefile:136: all] Error 2

[soumyaDghosh]

IIRC, there were various libraries back then not supported or properly optimized for s390x, including gnome-46-2404 as this content snap was targeted to be used with a content snap.