fix: allow alias renewal by re-submitting existing pair

Allow the same (address, alias) pair to be submitted again to refresh
the expiration. Uses ON DUPLICATE KEY UPDATE to reset created timestamp.

Author: wa0x6e

src/writer/alias.ts

@@ -14,14 +14,6 @@ export async function verify(message): Promise<any> {
     return Promise.reject('alias cannot be the same as the address');
   }
 
-  const existing = await db.queryAsync(
-    'SELECT 1 FROM aliases WHERE address = ? AND alias = ? LIMIT 1',
-    [message.address, msg.payload.alias]
-  );
-  if (existing.length > 0) {
-    return Promise.reject('alias already exists');
-  }
-
   return true;
 }
 
@@ -34,5 +26,8 @@ export async function action(message, ipfs, receipt, id): Promise<void> {
     alias: msg.payload.alias,
     created: msg.timestamp
   };
-  await db.queryAsync('INSERT INTO aliases SET ?', params);
+  await db.queryAsync(
+    'INSERT INTO aliases SET ? ON DUPLICATE KEY UPDATE id = VALUES(id), ipfs = VALUES(ipfs), created = VALUES(created)',
+    params
+  );
 }

test/integration/helpers/alias.test.ts

@@ -26,7 +26,7 @@ describe('alias', () => {
   });
 
   describe('verify()', () => {
-    it('should reject when alias already exists', async () => {
+    it('should pass when alias pair already exists (allows renewal)', async () => {
       const { address, alias } = aliasesSqlFixtures[0];
       const msg = {
         version: '0.1.4',
@@ -35,9 +35,7 @@ describe('alias', () => {
         payload: { alias }
       };
 
-      await expect(verify({ address, msg: JSON.stringify(msg) })).rejects.toMatch(
-        'alias already exists'
-      );
+      await expect(verify({ address, msg: JSON.stringify(msg) })).resolves.toBeTruthy();
     });
 
     it('should pass when alias does not exist', async () => {