fix: allow alias renewal by re-submitting existing pair

Allow the same (address, alias) pair to be submitted again to refresh
the expiration. Uses ON DUPLICATE KEY UPDATE to reset created timestamp.

Author: wa0x6e

src/writer/alias.ts

@@ -10,9 +10,10 @@ export async function verify(message): Promise<any> {
     log.warn(`[writer] Wrong alias format ${JSON.stringify(schemaIsValid)}`);
     return Promise.reject('wrong alias format');
   }
-  if (message.from === msg.payload.alias) {
+  if (message.address === msg.payload.alias) {
     return Promise.reject('alias cannot be the same as the address');
   }
+
   return true;
 }
 
@@ -25,5 +26,8 @@ export async function action(message, ipfs, receipt, id): Promise<void> {
     alias: msg.payload.alias,
     created: msg.timestamp
   };
-  await db.queryAsync('INSERT INTO aliases SET ?', params);
+  await db.queryAsync(
+    'INSERT INTO aliases SET ? ON DUPLICATE KEY UPDATE id = VALUES(id), ipfs = VALUES(ipfs), created = VALUES(created)',
+    params
+  );
 }

test/integration/helpers/alias.test.ts

@@ -1,32 +1,72 @@
 import { isExistingAlias } from '../../../src/helpers/alias';
 import db, { sequencerDB } from '../../../src/helpers/mysql';
+import { action, verify } from '../../../src/writer/alias';
 import { aliasesSqlFixtures } from '../../fixtures/alias';
 
 describe('alias', () => {
   const seed = Date.now().toFixed(0);
 
-  beforeAll(async () => {
-    await db.queryAsync('DELETE from snapshot_sequencer_test.aliases');
+  beforeEach(async () => {
+    await db.queryAsync('DELETE from snapshot_sequencer_test.aliases WHERE ipfs = ?', seed);
     await Promise.all(
       aliasesSqlFixtures.map(alias => {
-        const values = {
-          ...alias,
-          ipfs: seed
-        };
+        const values = { ...alias, ipfs: seed };
         return db.queryAsync('INSERT INTO snapshot_sequencer_test.aliases SET ?', values);
       })
     );
   });
 
-  afterEach(async () => {
-    await db.queryAsync('DELETE from snapshot_sequencer_test.aliases where ipfs = ?', seed);
-  });
-
   afterAll(async () => {
+    await db.queryAsync('DELETE from snapshot_sequencer_test.aliases WHERE ipfs = ?', seed);
     await db.endAsync();
     await sequencerDB.endAsync();
   });
 
+  describe('verify()', () => {
+    it('should pass when alias pair already exists (allows renewal)', async () => {
+      const { address, alias } = aliasesSqlFixtures[0];
+      const msg = {
+        version: '0.1.4',
+        timestamp: Math.floor(Date.now() / 1000),
+        type: 'alias',
+        payload: { alias }
+      };
+
+      await expect(verify({ address, msg: JSON.stringify(msg) })).resolves.toBeTruthy();
+    });
+
+    it('should bump created date when re-submitting existing alias', async () => {
+      const { address, alias } = aliasesSqlFixtures[0];
+      const newTimestamp = Math.floor(Date.now() / 1000) + 1000;
+      const msg = {
+        version: '0.1.4',
+        timestamp: newTimestamp,
+        type: 'alias',
+        payload: { alias }
+      };
+
+      await action({ address, msg: JSON.stringify(msg) }, 'ipfs-new', '', 'new-id');
+
+      const [row] = await db.queryAsync(
+        'SELECT created FROM aliases WHERE address = ? AND alias = ?',
+        [address, alias]
+      );
+      expect(row.created).toBe(newTimestamp);
+    });
+
+    it('should pass when alias does not exist', async () => {
+      const address = '0x0000000000000000000000000000000000000001';
+      const msg = {
+        version: '0.1.4',
+        timestamp: Math.floor(Date.now() / 1000),
+        type: 'alias',
+        payload: { alias: '0x0000000000000000000000000000000000000002' }
+      };
+
+      await expect(verify({ address, msg: JSON.stringify(msg) })).resolves.toBeTruthy();
+    });
+  });
+
   describe('isExistingAlias()', () => {
     it('should return true for valid alias', () => {
       expect(

test/unit/writer/alias.test.ts

@@ -2,7 +2,7 @@ import omit from 'lodash/omit';
 import * as writer from '../../../src/writer/alias';
 import input from '../../fixtures/writer-payload/alias.json';
 
-describe('writer/profile', () => {
+describe('writer/alias', () => {
   describe('verify()', () => {
     const msg = JSON.parse(input.msg);
     const invalidMsg = [