fix: fall back on ENS batch call exceptions (#478)

* fix: fall back on ENS batch call exceptions

Fixes #475

* test: cover ENS batch error capture

---------

Co-authored-by: chai3-bot <chai3-bot@users.noreply.github.com>

Author: chai3-bot

src/addressResolvers/ens.ts

@@ -35,12 +35,17 @@ export async function lookupAddresses(addresses: Address[]): Promise<Record<Addr
   if (normalizedAddresses.length === 0) return {};
 
   try {
-    const reverseRecords = await snapshot.utils.call(
-      provider,
-      abi,
-      ['0x3671aE578E63FdF66ad4F3E12CC0c0d71Ac7510C', 'getNames', [normalizedAddresses]],
-      { blockTag: 'latest' }
-    );
+    let reverseRecords: string[] = [];
+    try {
+      reverseRecords = await snapshot.utils.call(
+        provider,
+        abi,
+        ['0x3671aE578E63FdF66ad4F3E12CC0c0d71Ac7510C', 'getNames', [normalizedAddresses]],
+        { blockTag: 'latest' }
+      );
+    } catch (err: any) {
+      if (err?.code !== 'CALL_EXCEPTION') throw err;
+    }
     const validNames = normalizeEns(reverseRecords);
 
     // The batch contract only reads on-chain reverse records. Names served by

test/integration/addressResolvers/ens.test.ts

@@ -1,5 +1,12 @@
+import { capture } from '@snapshot-labs/snapshot-sentry';
+import snapshot from '@snapshot-labs/snapshot.js';
 import testAddressResolver from './helper';
 import { lookupAddresses, resolveNames } from '../../../src/addressResolvers/ens';
+import { FetchError } from '../../../src/addressResolvers/utils';
+
+jest.mock('@snapshot-labs/snapshot-sentry', () => ({
+  capture: jest.fn()
+}));
 
 testAddressResolver({
   name: 'ENS',
@@ -21,4 +28,29 @@ describe('ENS address resolver: CCIP-Read fallback', () => {
       [address]: 'avsa.eth'
     });
   }, 15e3);
+
+  it('falls back to per-address lookups when the batch reverse call reverts', async () => {
+    const ccipAddress = '0x3a872f8FED4421E7d5BE5c98Ab5Ea0e0245169A0';
+    const goodAddress = '0xE6D0Dd18C6C3a9Af8C2FaB57d6e6A38E29d513cC';
+
+    await expect(lookupAddresses([ccipAddress])).resolves.toEqual({});
+    await expect(lookupAddresses([ccipAddress, goodAddress])).resolves.toEqual({
+      [goodAddress]: 'sdntestens.eth'
+    });
+  }, 20e3);
+
+  it('still surfaces non-CALL_EXCEPTION batch errors', async () => {
+    const error = Object.assign(new Error('boom'), {
+      code: 'SERVER_ERROR'
+    });
+    const callSpy = jest.spyOn(snapshot.utils, 'call').mockRejectedValueOnce(error);
+    const address = '0xE6D0Dd18C6C3a9Af8C2FaB57d6e6A38E29d513cC';
+
+    try {
+      await expect(lookupAddresses([address])).rejects.toBeInstanceOf(FetchError);
+      expect(capture).toHaveBeenCalledWith(error, { input: { addresses: [address] } });
+    } finally {
+      callSpy.mockRestore();
+    }
+  });
 });