Skip to content

merge webmention task into receive task? #2644

Description

@snarfed

Right now, incoming webmentions don't use receive tasks. They get processed in their own webmention tasks instead, web.webmention_task. That task calls Protocol.receive (#529), so we don't have a lot of duplicated logic, but still, ideally they'd use receive tasks instead. I'd also consider moving the source page fetch and processing from async to sync, into the web.webmention_external handler.

A few catches:

  • the webmention task currently depends on Web.load setting Object.changed, which we'd lose across a new task. we'd need to propagate that into the receive task.
  • similar logic for setting the post's author, we'd need to propagate that too, and/or just set it on the object itself
  • webmentions determine internal based on the Authorization header. receive tasks determine it based on object id (URL) domain.

...I think that's all.

(Claude Code conversation: Receive task enqueue refactor)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions