-
Notifications
You must be signed in to change notification settings - Fork 512
Open
Description
Although adwaita-icon-theme is still a dependency on libgtk, it no longer supports applications outside of GNOME. Some of the symbolic icons it provided were simply removed, leading to regressions in many projects who relied on them.
Snes9x-gtk the front end in GTK for Snes9x actually use a few of those icons.
To replace the Adwaita symbolic icons a new XApp project was started called XSI (XApp Symbolic Icons): https://github.com/xapp-project/xapp-symbolic-icons.
This project provides a tool to inspect the icons usage and point those removed.
$ xsi-replace-adwaita-symbolic gtk/src
=== Exact matches (can be fixed) ===
=== Context matches (manual review) ===
gtk/src/gtk_preferences.cpp:87: entry->set_icon_from_icon_name("edit-clear", Gtk::ENTRY_ICON_SECONDARY); → xsi-edit-clear-symbolic (context)
gtk/src/snes9x.ui:4077: <property name="icon_name">video-display</property> → xsi-video-display-symbolic (context)
gtk/src/snes9x.ui:4490: <property name="icon_name">audio-x-generic</property> → xsi-audio-x-generic-symbolic (context)
gtk/src/snes9x.ui:4948: <property name="icon_name">utilities-terminal</property> → xsi-utilities-terminal-symbolic (context)
gtk/src/snes9x.ui:5379: <property name="icon_name">folder</property> → xsi-folder-symbolic (context)
gtk/src/snes9x.ui:6702: <property name="icon_name">input-gaming</property> → xsi-input-gaming-symbolic (context)
gtk/src/snes9x.ui:9054: <property name="icon_name">input-keyboard</property> → xsi-input-keyboard-symbolic (context)
Scan complete — 0 exact matches, 7 contextual matches found.
Now this open the question, actually many questions:
- We gonna move and use the
XSIsymbolic links or are we gonna ship our own icons or just "broken is fine"? - Are we gonna ship to
GTK 4soon or after/beforeGTK 3support ended or are weGTK 4ready already?
(by the way Arch Linux dropped GTK2 from the official repos just a few weeks ago) - Any other idea?
Metadata
Metadata
Assignees
Labels
No labels