chore: Updates pre-commit hooks to latest version and applies fixes

Author: Daverball

.pre-commit-config.yaml

@@ -1,10 +1,10 @@
 repos:
   - repo: https://github.com/psf/black
-    rev: 24.10.0
+    rev: 25.12.0
     hooks:
       - id: black
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v5.0.0
+    rev: v6.0.0
     hooks:
       - id: check-ast
       - id: check-added-large-files
@@ -19,7 +19,7 @@ repos:
       - id: mixed-line-ending
       - id: trailing-whitespace
   - repo: https://github.com/pycqa/flake8
-    rev: 7.1.1
+    rev: 7.3.0
     hooks:
       - id: flake8
         additional_dependencies: [
@@ -34,18 +34,24 @@ repos:
             'flake8-type-checking==2.9.1',
         ]
   - repo: https://github.com/asottile/pyupgrade
-    rev: v3.19.0
+    rev: v3.21.2
     hooks:
       - id: pyupgrade
         args: [ "--py39-plus", '--keep-runtime-typing' ]
   - repo: https://github.com/pycqa/isort
-    rev: 5.13.2
+    rev: 7.0.0
     hooks:
       - id: isort
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v1.13.0
+    rev: v1.19.1
     hooks:
       - id: mypy
         additional_dependencies:
           - pytest
           - flake8
+        # NOTE: We want this hook to always run, but exactly once
+        #       instead of for every file. So we exclude all files
+        exclude: '.*'
+        always_run: true
+        pass_filenames: false
+        args: ['-p', 'flake8_type_checking']

flake8_type_checking/checker.py

@@ -223,7 +223,7 @@ def visit_Constant(self, node: ast.Constant) -> ast.Constant:
             # just needs to be available in global scope anywhere, we handle
             # this by special casing `ast.Constant` when we look for used type
             # checking symbols
-            self.uses[node.value].append((node, self.current_scope))
+            self.uses[node.value].append((node, self.current_scope))  # type: ignore[index]
         return node
 
 
@@ -287,6 +287,7 @@ def visit_annotation_name(self, node: ast.Name) -> None:
 
     def visit_annotation_string(self, node: ast.Constant) -> None:
         """Add all the names in the string to mapped names."""
+        assert isinstance(node.value, str)
         visitor = StringAnnotationVisitor(self.plugin)
         visitor.parse_and_visit_string_annotation(node.value)
         self.plugin.soft_uses.update(visitor.names)
@@ -838,6 +839,7 @@ def visit_annotation_name(self, node: ast.Name) -> None:
 
     def visit_annotation_string(self, node: ast.Constant) -> None:
         """Parse and visit nested string annotations."""
+        assert isinstance(node.value, str)
         self.parse_and_visit_string_annotation(node.value)
 
 
@@ -902,6 +904,7 @@ def visit_annotation_name(self, node: ast.Name) -> None:
 
     def visit_annotation_string(self, node: ast.Constant) -> None:
         """Register wrapped annotation and invalid binop literals."""
+        assert isinstance(node.value, str)
         setattr(node, ANNOTATION_PROPERTY, True)
         # we don't want to register them as both so we don't emit redundant errors
         if getattr(node, BINOP_OPERAND_PROPERTY, False):
@@ -962,6 +965,7 @@ def visit_annotation_name(self, node: ast.Name) -> None:
 
     def visit_annotation_string(self, node: ast.Constant) -> None:
         """Collect all the names referenced inside the forward reference."""
+        assert isinstance(node.value, str)
         visitor = StringAnnotationVisitor(self._typing_lookup)
         visitor.parse_and_visit_string_annotation(node.value)
         self.quoted_names.update(visitor.names)
@@ -1178,7 +1182,7 @@ def are_annotations_deferred(self) -> bool:
         This is the case when either there is a `from __future__ import annotations`
         import present or we're targetting Python 3.14+.
         """
-        return self.py314plus or self.futures_annotation
+        return self.py314plus or self.futures_annotation is True
 
     def is_typing(self, node: ast.AST, symbol: str) -> bool:
         """Check if the given node matches the given typing symbol."""

tests/test_attrs.py

@@ -28,8 +28,7 @@ def test_attrs_model(imp, dec):
     Test `attrs` classes together with a non-`attrs` class that has a class var of the same type.
     `attrs` classes are instantiated using different dataclass decorators. The `attrs` module is imported as whole.
     """
-    example = textwrap.dedent(
-        f'''
+    example = textwrap.dedent(f'''
         {imp}
         from decimal import Decimal
 
@@ -43,8 +42,7 @@ class Y:
 
         class Z:
             x: Decimal
-        '''
-    )
+        ''')
     assert _get_error(example, error_code_filter='TC001,TC002,TC003') == set()
 
 
@@ -65,8 +63,7 @@ def test_complex_attrs_model(imp, dec, expected):
     Test `attrs` classes together with a non-`attrs` class tha has a class var of another type.
     `attrs` classes are instantiated using different dataclass decorators. The `attrs` module is imported as whole.
     """
-    example = textwrap.dedent(
-        f'''
+    example = textwrap.dedent(f'''
         {imp}
         from decimals import Decimal
         from decimal import Context
@@ -81,8 +78,7 @@ class Y:
 
         class Z:
             x: Context
-        '''
-    )
+        ''')
     assert _get_error(example, error_code_filter='TC001,TC002,TC003') == expected
 
 
@@ -103,8 +99,7 @@ def test_complex_attrs_model_direct_import(imp, dec, expected):
     Test `attrs` classes together with a non-`attrs` class tha has a class var of another type.
     `attrs` classes are instantiated using different dataclass decorators which are imported as submodules.
     """
-    example = textwrap.dedent(
-        f'''
+    example = textwrap.dedent(f'''
         {imp}
         from decimals import Decimal
         from decimal import Context
@@ -119,8 +114,7 @@ class Y:
 
         class Z:
             x: Context
-        '''
-    )
+        ''')
     assert _get_error(example, error_code_filter='TC001,TC002,TC003') == expected
 
 
@@ -150,8 +144,7 @@ def test_complex_attrs_model_as_import(imp, dec, expected):
     `attrs` classes are instantiated using different dataclass
     decorators which are imported as submodules using an alias.
     """
-    example = textwrap.dedent(
-        f'''
+    example = textwrap.dedent(f'''
         {imp}
         from decimals import Decimal
         from decimal import Context
@@ -166,8 +159,7 @@ class Y:
 
         class Z:
             x: Context
-        '''
-    )
+        ''')
     assert _get_error(example, error_code_filter='TC001,TC002,TC003') == expected
 
 
@@ -193,8 +185,7 @@ def test_complex_attrs_model_slots_frozen(imp, dec, expected):
     Test `attrs` classes together with a non-`attrs` class tha has a class var of another type.
     `attrs` classes are instantiated using different dataclass decorators and arguments.
     """
-    example = textwrap.dedent(
-        f'''
+    example = textwrap.dedent(f'''
         {imp}
         from decimals import Decimal
         from decimal import Context
@@ -209,6 +200,5 @@ class Y:
 
         class Z:
             x: Context
-        '''
-    )
+        ''')
     assert _get_error(example, error_code_filter='TC001,TC002,TC003') == expected