Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow-1763673 python3.13 support #2239

Merged
merged 58 commits into from
Mar 28, 2025
Merged

Snow-1763673 python3.13 support #2239

merged 58 commits into from
Mar 28, 2025
+197 −154

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski commented Mar 27, 2025 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
    Fixes SNOW-1763673

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    These new versions usually need no code-changes. They should just work on new Python versions. I also took this opportunity to update pre-commit hooks and fix all files.

  4. (Optional) PR for stored-proc connector:

sfc-gh-mkeller and others added 30 commits February 5, 2025 10:17
@sfc-gh-mkeller
deprecate python 3.8
195908a
@sfc-gh-mkeller
adding Python 3.13 builds
859db24
@sfc-gh-mkeller
pre-commit autoupdate
0f3e6a4
@sfc-gh-mkeller
fixing all files with pre-commit
8db96c5
@sfc-gh-mkeller
bump cibuildwheel used
a707ef4
@sfc-gh-mkeller
changelog entry
40e555d
@sfc-gh-mkeller
update numpy.nan usage
01384a6
@sfc-gh-mkeller
fix olddriver tests
92ee331
@sfc-gh-mkeller
update windows image used for builds and tests
7390bd9
@sfc-gh-mkeller
use already built wheels
fb4b1a8
@sfc-gh-mkeller
pre-commit fixes
c0c1df2
@sfc-gh-mkeller
bump numpy to <2.1.0
1ea64c6
@sfc-gh-mkeller
adding Python 3.13 Dockerfile
a5fd0dc
@sfc-gh-mkeller
fix numpy issues
580db9d
@sfc-gh-fpawlowski
SNOW-1763673: Merged main
e1faded
@sfc-gh-fpawlowski
Merge branch 'main' into mkeller/SNOW-1763673/python3.13-support
0536a8e
@sfc-gh-fpawlowski
SNOW-1763673: Added running python 313 tests on Jenkins and depricate…
bdc2956 
…d 3.8
@sfc-gh-fpawlowski
Merge remote-tracking branch 'origin/mkeller/SNOW-1763673/python3.13-…
ffdf66b 
…support' into mkeller/SNOW-1763673/python3.13-support
@sfc-gh-fpawlowski
Merge branch 'main' into mkeller/SNOW-1763673/python3.13-support
fffc947
@sfc-gh-fpawlowski
SNOW-1763673: Added python 313 to tox dependencies
e8655b8
@sfc-gh-fpawlowski
Merge remote-tracking branch 'origin/mkeller/SNOW-1763673/python3.13-…
c8a5aab 
…support' into mkeller/SNOW-1763673/python3.13-support
@sfc-gh-fpawlowski
SNOW-1763673: Reverted path env settinh
f37ad7e
@sfc-gh-fpawlowski
Merge branch 'main' into mkeller/SNOW-1763673/python3.13-support
1d3e227
@sfc-gh-fpawlowski
SNOW-1763673: Fixed failing old test with ubuntu downgrade
15527f7
@sfc-gh-fpawlowski
SNOW-1763673: Fixed fips dockerfile to include the new python version…
b843cbb 
…. Pinned down version of windows image
@sfc-gh-fpawlowski
Merge branch 'main' into mkeller/SNOW-1763673/python3.13-support
a3876d8
@sfc-gh-fpawlowski
Merge branch 'main' into mkeller/SNOW-1763673/python3.13-support
8651faa
@sfc-gh-fpawlowski
SNOW-1763673: Hardcoded list of versions of python supported fixed in…
b8fa4ad 
… tox
@sfc-gh-fpawlowski
SNOW-1763673: Build darwin cleanup
6132c8b
@sfc-gh-fpawlowski
SNOW-1763673: Added Jenkins builds
f5aea74
@sfc-gh-fpawlowski sfc-gh-fpawlowski self-assigned this Mar 27, 2025
@sfc-gh-fpawlowski sfc-gh-fpawlowski added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Mar 27, 2025
@sfc-gh-fpawlowski
Copy link
Contributor Author

Refactored from PR: #2105

@sfc-gh-fpawlowski sfc-gh-fpawlowski changed the title Snow 1763673 python3.13 support Snow-1763673 python3.13 support Mar 27, 2025
@sfc-gh-sghosh sfc-gh-sghosh mentioned this pull request Mar 28, 2025
Open
sfc-gh-mmishchenko
sfc-gh-mmishchenko approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@sfc-gh-mmishchenko sfc-gh-mmishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-mmishchenko sfc-gh-mmishchenko enabled auto-merge (squash) March 28, 2025 10:04
@sfc-gh-mmishchenko sfc-gh-mmishchenko merged commit ac24917 into main Mar 28, 2025
87 of 90 checks passed
@sfc-gh-mmishchenko sfc-gh-mmishchenko deleted the SNOW-1763673-python3.13-support branch March 28, 2025 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa Awaiting requested review from sfc-gh-pbulawa

Assignees

@sfc-gh-fpawlowski sfc-gh-fpawlowski

Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-fpawlowski @sfc-gh-astachowski @sfc-gh-mmishchenko @sfc-gh-pbulawa @sfc-gh-mkeller