SNOW-2019041: Remove Dependency on joda-time

Author: sfc-gh-wfateem

FIPS/pom.xml

@@ -450,10 +450,6 @@
                        <pattern>google.type</pattern>
                        <shadedPattern>${shadeBase}.google.type</shadedPattern>
                      </relocation>
-                     <relocation>
-                       <pattern>org.joda</pattern>
-                       <shadedPattern>${shadeBase}.joda</shadedPattern>
-                     </relocation>
                      <relocation>
                        <pattern>com.yammer</pattern>
                        <shadedPattern>${shadeBase}.yammer</shadedPattern>

parent-pom.xml

@@ -59,7 +59,6 @@
     <jacoco.skip.instrument>true</jacoco.skip.instrument>
     <javax.servlet.version>3.1.0</javax.servlet.version>
     <jna.version>5.13.0</jna.version>
-    <joda.time.version>2.8.1</joda.time.version>
     <json.smart.version>2.5.2</json.smart.version>
     <junit4.version>4.13.2</junit4.version>
     <junit.version>5.11.1</junit.version>
@@ -368,11 +367,6 @@
         <artifactId>javax.servlet-api</artifactId>
         <version>${javax.servlet.version}</version>
       </dependency>
-      <dependency>
-        <groupId>joda-time</groupId>
-        <artifactId>joda-time</artifactId>
-        <version>${joda.time.version}</version>
-      </dependency>
       <dependency>
         <groupId>net.minidev</groupId>
         <artifactId>json-smart</artifactId>
@@ -602,6 +596,12 @@
     <dependency>
       <groupId>com.amazonaws</groupId>
       <artifactId>aws-java-sdk-core</artifactId>
+      <exclusions>
+        <exclusion>
+          <groupId>joda-time</groupId>
+          <artifactId>joda-time</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>com.amazonaws</groupId>
@@ -691,10 +691,6 @@
       <groupId>javax.servlet</groupId>
       <artifactId>javax.servlet-api</artifactId>
     </dependency>
-    <dependency>
-      <groupId>joda-time</groupId>
-      <artifactId>joda-time</artifactId>
-    </dependency>
     <dependency>
       <groupId>net.minidev</groupId>
       <artifactId>json-smart</artifactId>

pom.xml

@@ -893,10 +893,6 @@
                       <pattern>google.type</pattern>
                       <shadedPattern>${shadeBase}.google.type</shadedPattern>
                     </relocation>
-                    <relocation>
-                      <pattern>org.joda</pattern>
-                      <shadedPattern>${shadeBase}.joda</shadedPattern>
-                    </relocation>
                     <relocation>
                       <pattern>com.yammer</pattern>
                       <shadedPattern>${shadeBase}.yammer</shadedPattern>

src/main/java/net/snowflake/client/core/EventHandler.java

@@ -9,6 +9,7 @@
 import java.io.PrintWriter;
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
+import java.time.Instant;
 import java.util.ArrayList;
 import java.util.Comparator;
 import java.util.Date;
@@ -27,7 +28,6 @@
 import java.util.zip.GZIPOutputStream;
 import net.snowflake.client.log.SFLogger;
 import net.snowflake.client.log.SFLoggerFactory;
-import org.joda.time.DateTime;
 
 public class EventHandler extends Handler {
   private static final SFLogger logger = SFLoggerFactory.getLogger(EventHandler.class);
@@ -98,7 +98,7 @@ public void run() {
   private final Map<String, AtomicInteger> incidentCounter;
 
   // Map
-  private final Map<String, DateTime> throttledIncidents;
+  private final Map<String, Instant> throttledIncidents;
 
   // Queue to buffer events while they are waiting to be flushed
   private final ArrayList<Event> eventBuffer;

thin_public_pom.xml

@@ -54,7 +54,6 @@
     <jackson.version>2.18.1</jackson.version>
     <javax.servlet.version>3.1.0</javax.servlet.version>
     <jna.version>5.13.0</jna.version>
-    <joda.time.version>2.8.1</joda.time.version>
     <json.smart.version>2.5.2</json.smart.version>
     <jsoup.version>1.15.3</jsoup.version>
     <metrics.version>2.2.0</metrics.version>
@@ -230,11 +229,6 @@
       <artifactId>javax.servlet-api</artifactId>
       <version>${javax.servlet.version}</version>
     </dependency>
-    <dependency>
-      <groupId>joda-time</groupId>
-      <artifactId>joda-time</artifactId>
-      <version>${joda.time.version}</version>
-    </dependency>
     <dependency>
       <groupId>net.java.dev.jna</groupId>
       <artifactId>jna</artifactId>