SNOW-1405682 - disable use of GCS default credentials as a default (#2117)

sfc-gh-pmotacki · web-flow · commit 32fa12c4c9ac · 2025-03-11T15:41:08.000+01:00
diff --git a/src/main/java/net/snowflake/client/core/SFBaseSession.java b/src/main/java/net/snowflake/client/core/SFBaseSession.java
@@ -145,7 +145,7 @@ public abstract class SFBaseSession {
   private boolean enableExactSchemaSearch = false;
 
   /** Disable lookup for default credentials by GCS library */
-  private boolean disableGcsDefaultCredentials = false;
+  private boolean disableGcsDefaultCredentials = true;
 
   private Map<String, Object> commonParameters;
 
diff --git a/src/main/java/net/snowflake/client/jdbc/cloud/storage/SnowflakeGCSClient.java b/src/main/java/net/snowflake/client/jdbc/cloud/storage/SnowflakeGCSClient.java
@@ -1372,8 +1372,7 @@ private static void overrideHost(StageInfo stage, StorageOptions.Builder builder
 
   private static boolean areDisabledGcsDefaultCredentials(SFSession session) {
     return session != null && session.getDisableGcsDefaultCredentials()
-        || convertSystemPropertyToBooleanValue(
-            DISABLE_GCS_DEFAULT_CREDENTIALS_PROPERTY_NAME, false);
+        || convertSystemPropertyToBooleanValue(DISABLE_GCS_DEFAULT_CREDENTIALS_PROPERTY_NAME, true);
   }
 
   private static boolean isSuccessStatusCode(int code) {

Original file line number	Diff line number	Diff line change
`@@ -1372,8 +1372,7 @@ private static void overrideHost(StageInfo stage, StorageOptions.Builder builder`
`1372`	`1372`
`1373`	`1373`	`private static boolean areDisabledGcsDefaultCredentials(SFSession session) {`
`1374`	`1374`	`return session != null && session.getDisableGcsDefaultCredentials()`
`1375`		`- \|\| convertSystemPropertyToBooleanValue(`
`1376`		`- DISABLE_GCS_DEFAULT_CREDENTIALS_PROPERTY_NAME, false);`
	`1375`	`+ \|\| convertSystemPropertyToBooleanValue(DISABLE_GCS_DEFAULT_CREDENTIALS_PROPERTY_NAME, true);`
`1377`	`1376`	`}`
`1378`	`1377`
`1379`	`1378`	`private static boolean isSuccessStatusCode(int code) {`