Skip to content

Commit b11dcc5

Browse files
Review comments implemented.
1 parent 911b03d commit b11dcc5

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

src/test/java/net/snowflake/client/core/auth/oauth/TokenResponseDTOTest.java

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import static org.junit.jupiter.api.Assertions.assertTrue;
55

66
import com.fasterxml.jackson.databind.ObjectMapper;
7-
import org.junit.jupiter.api.BeforeEach;
87
import org.junit.jupiter.api.Test;
98

109
public class TokenResponseDTOTest {
@@ -21,18 +20,11 @@ public class TokenResponseDTOTest {
2120
+ "\"refresh_token_expires_in\":7200"
2221
+ "}";
2322

24-
private TokenResponseDTO tokenResponseDTO;
25-
26-
@BeforeEach
27-
public void setUp() {
28-
// Setting up an example TokenResponseDTO
29-
tokenResponseDTO =
30-
new TokenResponseDTO(
31-
"abc123", "refresh123", "bearer", "read write", "testUser", true, 3600, 7200);
32-
}
33-
3423
@Test
3524
public void testConstructorAndGetters() {
25+
TokenResponseDTO tokenResponseDTO =
26+
new TokenResponseDTO(
27+
"abc123", "refresh123", "bearer", "read write", "testUser", true, 3600, 7200);
3628
// Assert that the constructor has correctly initialized the object
3729
assertEquals("abc123", tokenResponseDTO.getAccessToken());
3830
assertEquals("bearer", tokenResponseDTO.getTokenType());

src/test/java/net/snowflake/client/jdbc/cloud/storage/SnowflakeStorageClientTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@
1515
import net.snowflake.client.jdbc.FileBackedOutputStream;
1616
import net.snowflake.client.jdbc.MatDesc;
1717
import net.snowflake.client.jdbc.SnowflakeSQLLoggedException;
18-
import org.junit.jupiter.api.BeforeEach;
18+
import org.junit.jupiter.api.BeforeAll;
1919
import org.junit.jupiter.api.Test;
2020

2121
class SnowflakeStorageClientTest {
2222

2323
private SnowflakeStorageClient storageClient;
2424

25-
@BeforeEach
25+
@BeforeAll
2626
void setUp() {
2727
// Mock an implementation of the interface
2828
storageClient =

0 commit comments

Comments
 (0)