Skip to content

Commit c48c9a4

Browse files
minor fixes
1 parent a3906c0 commit c48c9a4

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

src/test/java/net/snowflake/client/authentication/AuthConnectionParameters.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ static Properties getOAuthSnowflakeWildcardsAuthorizationCodeConnectionParameter
106106
return properties;
107107
}
108108

109-
static Properties getOAuthSnowflakeClientCredentialParameters() {
109+
static Properties getOAuthOktaClientCredentialParameters() {
110110
Properties properties = getBaseConnectionParameters();
111111
properties.put("authenticator", "OAUTH_CLIENT_CREDENTIALS");
112112
properties.put(

src/test/java/net/snowflake/client/authentication/OauthOktaClientCredentialsLatestIT.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package net.snowflake.client.authentication;
22

33
import static net.snowflake.client.authentication.AuthConnectionParameters.OKTA;
4-
import static net.snowflake.client.authentication.AuthConnectionParameters.getOAuthSnowflakeClientCredentialParameters;
4+
import static net.snowflake.client.authentication.AuthConnectionParameters.getOAuthOktaClientCredentialParameters;
55

66
import java.io.IOException;
77
import java.util.Properties;
@@ -14,20 +14,20 @@
1414

1515
@Tag(TestTags.AUTHENTICATION)
1616
public class OauthOktaClientCredentialsLatestIT {
17-
Properties properties = getOAuthSnowflakeClientCredentialParameters();
17+
Properties properties = getOAuthOktaClientCredentialParameters();
1818
String login = properties.getProperty("user");
1919
AuthTestHelper authTestHelper = new AuthTestHelper();
2020

2121
@BeforeEach
2222
public void setUp() throws IOException {
2323
AuthTestHelper.deleteIdToken(AuthConnectionParameters.HOST, login);
2424
AuthTestHelper.deleteOauthToken(OKTA, login);
25-
properties = getOAuthSnowflakeClientCredentialParameters();
25+
properties = getOAuthOktaClientCredentialParameters();
2626
}
2727

2828
@AfterAll
2929
public static void tearDown() {
30-
Properties properties = getOAuthSnowflakeClientCredentialParameters();
30+
Properties properties = getOAuthOktaClientCredentialParameters();
3131
AuthTestHelper.deleteIdToken(AuthConnectionParameters.HOST, properties.getProperty("user"));
3232
AuthTestHelper.deleteOauthToken(OKTA, properties.getProperty("user"));
3333
}

src/test/java/net/snowflake/client/authentication/PATLatestIT.java

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,27 +15,26 @@
1515
import java.text.SimpleDateFormat;
1616
import java.util.Date;
1717
import java.util.Properties;
18+
import net.snowflake.client.category.TestTags;
1819
import org.junit.jupiter.api.BeforeEach;
20+
import org.junit.jupiter.api.Tag;
1921
import org.junit.jupiter.api.Test;
2022

23+
@Tag(TestTags.AUTHENTICATION)
2124
public class PATLatestIT {
2225

2326
AuthTestHelper authTestHelper;
24-
Properties properties;
25-
String token;
2627
String patName;
2728

2829
@BeforeEach
2930
public void setUp() throws IOException {
3031
authTestHelper = new AuthTestHelper();
31-
properties = getPATConnectionParameters();
3232
}
3333

3434
@Test
3535
void shouldAuthenticateUsingPAT() {
3636
Properties properties = getPATConnectionParameters();
37-
token = getPAT();
38-
properties.put("token", token);
37+
properties.put("token", getPAT());
3938
authTestHelper.connectAndExecuteSimpleQuery(properties, null);
4039
authTestHelper.verifyExceptionIsNotThrown();
4140
removePAT();
@@ -52,8 +51,7 @@ void shouldThrowErrorForInvalidPAT() {
5251
@Test
5352
void shouldThrowErrorForMismatchedPATUsername() throws IOException {
5453
Properties properties = getPATConnectionParameters();
55-
token = getPAT();
56-
properties.put("token", token);
54+
properties.put("token", getPAT());
5755
properties.put("user", "differentUsername");
5856
authTestHelper.connectAndExecuteSimpleQuery(properties, null);
5957
authTestHelper.verifyExceptionIsThrown("Programmatic access token is invalid.");

0 commit comments

Comments
 (0)