Skip to content

SNOW-1902245: Accept v1 and v2 Entra ID issuers#2158

Merged
sfc-gh-dheyman merged 3 commits intosnowflakedb:masterfrom
sfc-gh-pmansour:pmansour/accept-v1-and-v2-entra-issuers
Apr 18, 2025
Merged

SNOW-1902245: Accept v1 and v2 Entra ID issuers#2158
sfc-gh-dheyman merged 3 commits intosnowflakedb:masterfrom
sfc-gh-pmansour:pmansour/accept-v1-and-v2-entra-issuers

Conversation

@sfc-gh-pmansour
Copy link
Copy Markdown
Contributor

@sfc-gh-pmansour sfc-gh-pmansour commented Apr 17, 2025

Overview

SNOW-1902245 Accept both v1 and v2 formats of Entra ID issuers

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown
Contributor

sfc-gh-snowflakedb-snyk-sa commented Apr 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Apr 17, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 2b9d03d src/test/resources/wiremock/mappings/wif/azure/successful_flow_azure_functions_v2_issuer.json View secret
🛠 Guidelines to remediate hardcoded secrets

The above secret(s) have been detected in your PR. Please take an appropriate action for each secret:

  • If it’s a true positive, remove the secret from source code, revoke it and migrate to a secure way of storing and accessing secrets (see http://go/secrets-and-code). Once that’s done, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and resolve the incident.
  • If it’s a false positive, go to the incidents page linked in the “GitGuardian id” column (log in using SnowBiz Okta) and ignore the incident.
  • If you didn't add this secret - and only then - you may ignore this check as it's non-blocking. If you did add the secret and you ignore this check, you'll be assigned a "Security Finding" ticket in Jira in a few days.

Note:

  • A secret is considered leaked from the moment it touches GitHub. Rewriting git history by force pushing or other means is not necessary and doesn’t change the fact that the secret has to be revoked.
  • This check has a “Skip: false positive” button. Don’t use it. It will mark all detected secrets as false positives but only in the context of this specific run - it won’t remember this action in subsequent check runs.

If you encounter any problems you can reach out to us on Slack: #gitguardian-secret-scanning-help


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sfc-gh-pmansour sfc-gh-pmansour changed the title Accept v1 and v2 Entra ID issuers SNOW-1902245: Accept v1 and v2 Entra ID issuers Apr 17, 2025
@sfc-gh-pmansour sfc-gh-pmansour marked this pull request as ready for review April 17, 2025 17:04
@sfc-gh-pmansour sfc-gh-pmansour requested a review from a team as a code owner April 17, 2025 17:04
@sfc-gh-pmansour
Copy link
Copy Markdown
Contributor Author

The failing CI tests don't look related to this change.

@sfc-gh-dheyman and others, what's the best way to proceed here?

@sfc-gh-dheyman
Copy link
Copy Markdown
Collaborator

We're working currently on fixing this failing test, but this is something out of scope of this PR.

@sfc-gh-dheyman sfc-gh-dheyman merged commit 904c861 into snowflakedb:master Apr 18, 2025
144 of 279 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants