Skip to content

NO-SNOW: debug test failures never merge#2183

Closed
sfc-gh-ext-simba-hx wants to merge 1 commit intomasterfrom
no-snow-debug-for-test-failures
Closed

NO-SNOW: debug test failures never merge#2183
sfc-gh-ext-simba-hx wants to merge 1 commit intomasterfrom
no-snow-debug-for-test-failures

Conversation

@sfc-gh-ext-simba-hx
Copy link
Copy Markdown
Collaborator

Overview

SNOW-XXXXX

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx requested a review from a team as a code owner May 15, 2025 00:38
@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx marked this pull request as draft May 15, 2025 00:38
@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown
Contributor

sfc-gh-snowflakedb-snyk-sa commented May 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-ext-simba-hx
Copy link
Copy Markdown
Collaborator Author

Expected result confirmed. Don't need this anymore.

@sfc-gh-ext-simba-hx sfc-gh-ext-simba-hx deleted the no-snow-debug-for-test-failures branch May 15, 2025 16:14
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants