Skip to content

SNOW-2021007 refactor error codes usage in tests #2184

Merged
sfc-gh-akolodziejczyk merged 3 commits intomasterfrom
SNOW-2021007-part3
May 21, 2025
Merged

SNOW-2021007 refactor error codes usage in tests #2184
sfc-gh-akolodziejczyk merged 3 commits intomasterfrom
SNOW-2021007-part3

Conversation

@sfc-gh-akolodziejczyk
Copy link
Copy Markdown
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented May 15, 2025

Overview

SNOW-2021007

  • use error code from ErrorCode whenever possible, to make it clear it's jdbc driver error code
  • remove GS error code details in cases when it's not relevant to the test case
  • minor fixes

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-snowflakedb-snyk-sa
Copy link
Copy Markdown
Contributor

sfc-gh-snowflakedb-snyk-sa commented May 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk changed the title SNOW-2021007 refactor tests using error codes SNOW-2021007 refactor error codes usage in tests May 15, 2025
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review May 19, 2025 10:40
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner May 19, 2025 10:40
Copy link
Copy Markdown
Contributor

@sfc-gh-pcyrek sfc-gh-pcyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk merged commit 1e36211 into master May 21, 2025
146 checks passed
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the SNOW-2021007-part3 branch May 21, 2025 14:21
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants