Skip to content

Commit bc40a3a

Browse files
author
Paul Boocock
committed
Prevent the Activity Tracking timer being enabled twice with duplicate enableActivityTracking calls (close #975)
1 parent 725b830 commit bc40a3a

File tree

1 file changed

+17
-13
lines changed

1 file changed

+17
-13
lines changed

src/js/tracker.js

+17-13
Original file line numberDiff line numberDiff line change
@@ -1711,7 +1711,7 @@ export function Tracker(functionName, namespace, version, mutSnowplowState, argm
17111711
};
17121712
}
17131713

1714-
warn('Activity tracking not enabled, please provide integer values for minimumVisitLength and heartBeatDelay.');
1714+
warn('Activity tracking minimumVisitLength & heartbeatDelay must be integers');
17151715
return {};
17161716
}
17171717

@@ -2164,12 +2164,14 @@ export function Tracker(functionName, namespace, version, mutSnowplowState, argm
21642164
* @param int heartBeatDelay Seconds to wait between pings
21652165
*/
21662166
apiMethods.enableActivityTracking = function (minimumVisitLength, heartBeatDelay) {
2167-
activityTrackingConfig.enabled = true;
2168-
activityTrackingConfig.configurations.pagePing = configureActivityTracking(
2169-
minimumVisitLength,
2170-
heartBeatDelay,
2171-
logPagePing
2172-
);
2167+
if (!activityTrackingConfig.configurations.pagePing) {
2168+
activityTrackingConfig.enabled = true;
2169+
activityTrackingConfig.configurations.pagePing = configureActivityTracking(
2170+
minimumVisitLength,
2171+
heartBeatDelay,
2172+
logPagePing
2173+
);
2174+
}
21732175
};
21742176

21752177
/**
@@ -2180,12 +2182,14 @@ export function Tracker(functionName, namespace, version, mutSnowplowState, argm
21802182
* @param function callback function called with ping data
21812183
*/
21822184
apiMethods.enableActivityTrackingCallback = function (minimumVisitLength, heartBeatDelay, callback) {
2183-
activityTrackingConfig.enabled = true;
2184-
activityTrackingConfig.configurations.callback = configureActivityTracking(
2185-
minimumVisitLength,
2186-
heartBeatDelay,
2187-
callback
2188-
);
2185+
if (!activityTrackingConfig.configurations.callback) {
2186+
activityTrackingConfig.enabled = true;
2187+
activityTrackingConfig.configurations.callback = configureActivityTracking(
2188+
minimumVisitLength,
2189+
heartBeatDelay,
2190+
callback
2191+
);
2192+
}
21892193
};
21902194

21912195
/**

0 commit comments

Comments
 (0)