Skip to content

Commit e97528c

Browse files
matus-tomleingreg-el
authored andcommitted
Update vendor and version of the player schema used in the media plugin (close #1222)
PR #1223
1 parent bb92a45 commit e97528c

File tree

3 files changed

+13
-2
lines changed

3 files changed

+13
-2
lines changed
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"changes": [
3+
{
4+
"packageName": "@snowplow/browser-plugin-media",
5+
"comment": "Update version of the player schema used in the media plugin to 2-0-0 (#1222)",
6+
"type": "none"
7+
}
8+
],
9+
"packageName": "@snowplow/browser-plugin-media"
10+
}

plugins/browser-plugin-media/src/schemata.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { MediaEventType } from './types';
22

33
const MEDIA_SCHEMA_PREFIX = 'iglu:com.snowplowanalytics.snowplow.media/';
44
const MEDIA_SCHEMA_SUFFIX = '/jsonschema/1-0-0';
5-
export const MEDIA_PLAYER_SCHEMA = MEDIA_SCHEMA_PREFIX + 'player' + MEDIA_SCHEMA_SUFFIX;
5+
// NOTE: The player schema has a different vendor than the other media schemas because it builds on an older version of the same schema. Versions 3.12 to 3.13.1 of the media plugin used a conflicting schema URI which has since been removed from Iglu Central.
6+
export const MEDIA_PLAYER_SCHEMA = 'iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/2-0-0';
67
export const MEDIA_SESSION_SCHEMA = MEDIA_SCHEMA_PREFIX + 'session' + MEDIA_SCHEMA_SUFFIX;
78
export const MEDIA_AD_SCHEMA = MEDIA_SCHEMA_PREFIX + 'ad' + MEDIA_SCHEMA_SUFFIX;
89
export const MEDIA_AD_BREAK_SCHEMA = MEDIA_SCHEMA_PREFIX + 'ad_break' + MEDIA_SCHEMA_SUFFIX;

trackers/javascript-tracker/test/integration/vimeo.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const makeContext = () => {
2424
schema: 'iglu:com.snowplowanalytics.snowplow/contexts/jsonschema/1-0-0',
2525
data: [
2626
{
27-
schema: 'iglu:com.snowplowanalytics.snowplow.media/player/jsonschema/1-0-0',
27+
schema: 'iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/2-0-0',
2828
data: {
2929
currentTime: jasmine.any(Number),
3030
paused: jasmine.any(Boolean),

0 commit comments

Comments
 (0)