Skip to content

Commit 844ca2e

Browse files
committed
Run integration tests in separate jobs in CI (#30)
Integration tests take long time to run. Running them in separate jobs allows to run them parallel and this significantly reduces the time tests take.
1 parent ad16b7e commit 844ca2e

File tree

2 files changed

+59
-2
lines changed
  • .github/workflows
  • pubsub/src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/sinks

2 files changed

+59
-2
lines changed

.github/workflows/test.yml

Lines changed: 58 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ name: test
33
on: push
44

55
jobs:
6-
test:
6+
unit-tests:
77
if: ${{ github.event.repository.private == true }}
88
runs-on: ubuntu-latest
99
steps:
@@ -25,9 +25,66 @@ jobs:
2525
run: sbt scalafmtCheckAll
2626
- name: Run unit tests
2727
run: sbt +test
28+
29+
it-kinesis:
30+
if: ${{ github.event.repository.private == true }}
31+
runs-on: ubuntu-latest
32+
steps:
33+
- uses: actions/checkout@v4
34+
- uses: coursier/cache-action@v6
35+
- name: Set up JDK
36+
uses: actions/setup-java@v4
37+
with:
38+
java-version: 21
39+
distribution: 'temurin'
40+
- name: Install Thrift
41+
uses: awalsh128/cache-apt-pkgs-action@latest
42+
with:
43+
packages: libthrift-java thrift-compiler
44+
version: 1.0
45+
- name: Install sbt
46+
uses: sbt/setup-sbt@v1
2847
- name: Run integration tests Kinesis
2948
run: sbt "project kinesisDistroless" IntegrationTest/test
49+
50+
it-pubsub:
51+
if: ${{ github.event.repository.private == true }}
52+
runs-on: ubuntu-latest
53+
steps:
54+
- uses: actions/checkout@v4
55+
- uses: coursier/cache-action@v6
56+
- name: Set up JDK
57+
uses: actions/setup-java@v4
58+
with:
59+
java-version: 21
60+
distribution: 'temurin'
61+
- name: Install Thrift
62+
uses: awalsh128/cache-apt-pkgs-action@latest
63+
with:
64+
packages: libthrift-java thrift-compiler
65+
version: 1.0
66+
- name: Install sbt
67+
uses: sbt/setup-sbt@v1
3068
- name: Run integration tests PubSub
3169
run: sbt "project pubsubDistroless" IntegrationTest/test
70+
71+
it-kafka:
72+
if: ${{ github.event.repository.private == true }}
73+
runs-on: ubuntu-latest
74+
steps:
75+
- uses: actions/checkout@v4
76+
- uses: coursier/cache-action@v6
77+
- name: Set up JDK
78+
uses: actions/setup-java@v4
79+
with:
80+
java-version: 21
81+
distribution: 'temurin'
82+
- name: Install Thrift
83+
uses: awalsh128/cache-apt-pkgs-action@latest
84+
with:
85+
packages: libthrift-java thrift-compiler
86+
version: 1.0
87+
- name: Install sbt
88+
uses: sbt/setup-sbt@v1
3289
- name: Run integration tests Kafka
3390
run: sbt "project kafkaDistroless" IntegrationTest/test

pubsub/src/main/scala/com.snowplowanalytics.snowplow.collectors.scalastream/sinks/PubSubSink.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ import org.typelevel.log4cats.Logger
1616
import org.typelevel.log4cats.slf4j.Slf4jLogger
1717

1818
import com.snowplowanalytics.snowplow.streams.pubsub.{
19+
PubsubSinkConfig => CommonPubsubSinkConfig,
1920
PubsubFactory,
20-
PubsubSinkConfig => CommonPubsubSinkConfig,
2121
PubsubSinkConfigM => CommonPubsubSinkConfigM
2222
}
2323
import com.snowplowanalytics.snowplow.collector.core.{Config, Sink}

0 commit comments

Comments
 (0)