Skip to content

Commit 80d438b

Browse files
committed
fix: make ResultProperties.Policy nillable
1 parent c1be7d5 commit 80d438b

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

internal/analysis/analysis_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,10 @@ func TestAnalysis_RunAnalysis(t *testing.T) {
347347

348348
require.NoError(t, err)
349349
assert.Equal(t, "scripts/db/migrations/20230811153738_add_generated_grouping_columns_to_collections_table.ts", actual.Sarif.Runs[0].Results[0].Locations[0].PhysicalLocation.ArtifactLocation.URI)
350+
351+
t.Run("should default policy to nil if not provided", func(t *testing.T) {
352+
assert.Nil(t, actual.Sarif.Runs[0].Results[0].Properties.Policy)
353+
})
350354
}
351355

352356
func TestAnalysis_RunAnalysis_TriggerFunctionError(t *testing.T) {

sarif/sarif_types.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,18 +89,20 @@ type Fingerprints struct {
8989
Identity string `json:"identity"`
9090
}
9191

92+
type Policy struct {
93+
OriginalLevel string `json:"originalLevel"`
94+
OriginalSeverity string `json:"originalSeverity"`
95+
Severity string `json:"severity"`
96+
}
97+
9298
type ResultProperties struct {
9399
PriorityScore int `json:"priorityScore"`
94100
PriorityScoreFactors []struct {
95101
Label bool `json:"label"`
96102
Type string `json:"type"`
97103
} `json:"priorityScoreFactors"`
98-
IsAutofixable bool `json:"isAutofixable"`
99-
Policy struct {
100-
OriginalLevel string `json:"originalLevel"`
101-
OriginalSeverity string `json:"originalSeverity"`
102-
Severity string `json:"severity"`
103-
} `json:"snykPolicy/v1"`
104+
IsAutofixable bool `json:"isAutofixable"`
105+
Policy *Policy `json:"snykPolicy/v1,omitempty"`
104106
}
105107

106108
type Result struct {

0 commit comments

Comments
 (0)