fix: use GetWithError instead of only Get when accessing sast settings in gaf config

Author: acke

README.md

@@ -338,7 +338,7 @@ Right now the language server supports the following actions:
 - `SettingsSastEnabled` triggers the api call to check if Snyk Code is enabled
   - command: `snyk.getSettingsSastEnabled`
   - args: empty
-  - returns `true` if enabled, `false` if not, or an error and false if an error occurred
+  - returns a `*sast_contract.SastResponse` or, or an error and false if an error occurred
 - `GetActiveUser` triggers the api call to get the active logged in user or an error if not logged in
   - command: `snyk.getActiveUser`
   - args: empty

domain/ide/command/sast_enabled.go

@@ -48,7 +48,10 @@ func (cmd *sastEnabled) Execute(_ context.Context) (any, error) {
 	}
 
 	gafConfig := cmd.c.Engine().GetConfiguration()
-	sastResponse := gafConfig.Get(code_workflow.ConfigurationSastSettings)
+	sastResponse, err := gafConfig.GetWithError(code_workflow.ConfigurationSastSettings)
+	if err != nil {
+		return nil, err
+	}
 
 	return sastResponse, nil
 }

infrastructure/code/code.go

@@ -33,6 +33,8 @@ import (
 	codeClient "github.com/snyk/code-client-go"
 	codeClientObservability "github.com/snyk/code-client-go/observability"
 	"github.com/snyk/code-client-go/scan"
+	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow"
+	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow/sast_contract"
 	"github.com/snyk/go-application-framework/pkg/utils"
 
 	"github.com/snyk/snyk-ls/internal/types"
@@ -46,9 +48,6 @@ import (
 	"github.com/snyk/snyk-ls/internal/product"
 	"github.com/snyk/snyk-ls/internal/progress"
 	"github.com/snyk/snyk-ls/internal/uri"
-
-	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow"
-	"github.com/snyk/go-application-framework/pkg/local_workflows/code_workflow/sast_contract"
 )
 
 type ScanStatus struct {
@@ -152,7 +151,16 @@ func (sc *Scanner) Scan(ctx context.Context, path types.FilePath, folderPath typ
 	}
 
 	gafConfig := sc.C.Engine().GetConfiguration()
-	sastResponse, ok := gafConfig.Get(code_workflow.ConfigurationSastSettings).(*sast_contract.SastResponse)
+
+	response, err := gafConfig.GetWithError(code_workflow.ConfigurationSastSettings)
+	if err != nil {
+		return nil, err
+	}
+
+	sastResponse, ok := response.(*sast_contract.SastResponse)
+	if !ok {
+		return nil, errors.New("Failed to get the sast settings")
+	}
 
 	if sastResponse == nil || !ok {
 		return issues, errors.New("Failed to get the sast settings")