fix: don't fail run when there are missing modulegraphs - ignore them and continue (#158)

If configs are missing moduleGraphs (e.g., because they are custom configs) we log them and ignore them, instead of failing the entire job. This allows more graceful handling of large mono repos which may have multiple custom configs.

Author: andrewrobinsonhodges-snyk

scala/SnykSbtPlugin-0.1x.scala

@@ -94,15 +94,22 @@ object SnykSbtPlugin extends AutoPlugin {
         ConfigBlacklist.contains(c.name) || !c.isPublic
       }
       val filter = ScopeFilter(configurations = inConfigurations(thisProjectConfigs: _*))
+      // Use `moduleGraph.?` so configurations that don't have `moduleGraph` defined (e.g. user-defined configs) are
+      // skipped instead of failing the whole task graph with sbt.internal.util.Init$RuntimeUndefined.
       val configAndModuleGraph = Def.task {
-        val graph = moduleGraph.value
         val configName = configuration.value.name
+        val log = streams.value.log
 
-        configName -> graph
+        moduleGraph.?.value match {
+          case Some(graph) => Some(configName -> graph)
+          case None =>
+            log.warn(s"[snyk] Skipping configuration '$configName' - no moduleGraph defined")
+            None
+        }
       }
 
       Def.task {
-        val graphs = configAndModuleGraph.all(filter).value
+        val graphs = configAndModuleGraph.all(filter).value.flatten
 
         graphs.foldLeft(SnykProjectData(thisProjectId, Map.empty, Map.empty)) {
           case (projectData, (configName, graph)) =>

scala/SnykSbtPlugin-1.2x.scala

@@ -90,14 +90,21 @@ object SnykSbtPlugin extends AutoPlugin {
         ConfigBlacklist.contains(c.name) || !c.isPublic
       }
       val filter             = ScopeFilter(configurations = inConfigurations(thisProjectConfigs: _*))
+      // Use `moduleGraph.?` so configurations that don't have `moduleGraph` defined (e.g. user-defined configs) are
+      // skipped instead of failing the whole task graph with sbt.internal.util.Init$RuntimeUndefined.
       val configAndModuleGraph = Def.task {
-        val graph      = moduleGraph.value
         val configName = configuration.value.name
-        configName -> graph
+        val log        = streams.value.log
+        moduleGraph.?.value match {
+          case Some(graph) => Some(configName -> graph)
+          case None        =>
+            log.warn(s"[snyk] Skipping configuration '$configName' - no moduleGraph defined")
+            None
+        }
       }
 
       Def.task {
-        val graphs = configAndModuleGraph.all(filter).value
+        val graphs = configAndModuleGraph.all(filter).value.flatten
 
         graphs.foldLeft(SnykProjectData(thisProjectId, Map.empty, Map.empty)) {
           case (projectData, (configName, graph)) =>

test/fixtures/testproj-1.10-custom-config/build.sbt

@@ -0,0 +1,19 @@
+// Regression fixture with a public, non-standard sbt configuration, specifically missing the `moduleGraph` task.
+//
+// The Protobuf config below is intentionally declared without DependencyTreeSettings so that
+// `Protobuf / moduleGraph` is undefined. The plugin should skip configs missing `moduleGraph` instead of failing the
+// whole task graph.
+lazy val Protobuf = config("protobuf")
+
+lazy val root = (project in file("."))
+  .configs(Protobuf)
+  .settings(
+    inThisBuild(List(
+      organization := "com.example",
+      scalaVersion := "2.12.16",
+      version      := "0.1.0-SNAPSHOT"
+    )),
+    name := "Hello",
+    libraryDependencies += "axis" % "axis" % "1.4",
+    inConfig(Protobuf)(Defaults.configSettings)
+  )

test/fixtures/testproj-1.10-custom-config/project/build.properties

@@ -0,0 +1 @@
+sbt.version=1.10.7

test/fixtures/testproj-1.10-custom-config/project/plugins.sbt

@@ -0,0 +1 @@
+addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.10.0-RC1")

test/system/plugin.test.ts

@@ -138,6 +138,19 @@ test('run legacy inspect() on sbt 1.4.0 with sbt-dependency-graph new naming- ad
   expect(result.package.dependencies['axis:axis'].version).toBe('1.4');
 });
 
+test('run inspect() on project with custom non-standard config (missing moduleGraph)', async () => {
+  const result: any = await plugin.inspect(
+    fixtureDir,
+    'testproj-1.10-custom-config/build.sbt',
+    {},
+  );
+
+  // Plugin path should run to completion instead of falling back to legacy `bundled:sbt`.
+  expect(result.plugin.name).toBe('snyk:sbt');
+  expect(result.package.packageFormatVersion).toBe('mvn:0.0.1');
+  expect(result.package.dependencies['axis:axis'].version).toBe('1.4');
+});
+
 test('run inspect() proj with provided 1.7', async () => {
   const result = await plugin.inspect(
     fixtureDir,