Skip to content

Commit 1a0f6bb

Browse files
authored
Merge pull request #1241 from scorealarm/bugfix/adds-missing-character-for-url-encoding
Adds missing character for url encoding
2 parents 5dcfe18 + 5611c8a commit 1a0f6bb

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Diff for: Source/SocketIO/Util/SocketExtensions.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ extension Array {
3838

3939
extension CharacterSet {
4040
static var allowedURLCharacterSet: CharacterSet {
41-
return CharacterSet(charactersIn: "!*'();:@&=+$,/?%#[]\" {}^").inverted
41+
return CharacterSet(charactersIn: "!*'();:@&=+$,/?%#[]\" {}^|").inverted
4242
}
4343
}
4444

Diff for: Tests/TestSocketIO/SocketEngineTest.swift

+3-3
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,11 @@ class SocketEngineTest: XCTestCase {
8787
XCTAssertEqual(engine.urlWebSocket.query, "transport=websocket&created=2016-05-04T18%3A31%3A15%2B0200")
8888

8989
engine.connectParams = [
90-
"forbidden": "!*'();:@&=+$,/?%#[]\" {}^"
90+
"forbidden": "!*'();:@&=+$,/?%#[]\" {}^|"
9191
]
9292

93-
XCTAssertEqual(engine.urlPolling.query, "transport=polling&b64=1&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D%5E")
94-
XCTAssertEqual(engine.urlWebSocket.query, "transport=websocket&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D%5E")
93+
XCTAssertEqual(engine.urlPolling.query, "transport=polling&b64=1&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D%5E%7C")
94+
XCTAssertEqual(engine.urlWebSocket.query, "transport=websocket&forbidden=%21%2A%27%28%29%3B%3A%40%26%3D%2B%24%2C%2F%3F%25%23%5B%5D%22%20%7B%7D%5E%7C")
9595
}
9696

9797
func testBase64Data() {

0 commit comments

Comments
 (0)