Fix defer_stop usage in HTTP1::Server. (#215)

Author: samuel-williams-shopify

lib/async/http/protocol/http1/server.rb

@@ -64,21 +64,22 @@ def each(task: Task.current)
 						task.annotate("Reading #{self.version} requests for #{self.class}.")
 
 						while request = next_request
-							if body = request.body
-								finishable = Finishable.new(body)
-								request.body = finishable
-							end
-							
-							response = yield(request, self)
-							version = request.version
-							body = response&.body
-							
-							if hijacked?
-								body&.close
-								return
-							end
-							
+							# We have received complete request (line + headers), so defer stop until the response is generated.
 							task.defer_stop do
+								if body = request.body
+									finishable = Finishable.new(body)
+									request.body = finishable
+								end
+								
+								response = yield(request, self)
+								version = request.version
+								body = response&.body
+								
+								if hijacked?
+									body&.close
+									return
+								end
+								
 								# If a response was generated, send it:
 								if response
 									trailer = response.headers.trailer!

releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## Unreleased
+
+  - Fix `defer_stop` usage in `HTTP1::Server`, improving server graceful shutdown behavior.
+
 ## v0.94.0
 
   - Propagate all errors from background reader to active streams so that they are closed correctly (e.g. errors are not missed).