-
-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Similar to AlphabetiseModList, the IsSorted method in Utilities.cs operates directly on a BindingList<Mod>. The sorting check itself is a piece of core logic that doesn't strictly belong in a UI-focused list type.
To maintain a cleaner separation, the sorting validation should be performed on a core collection type.
Action:
- Create a new method in a core-level class (e.g.,
ModService.csorCollectionsUtils.cs) that accepts aList<Mod>and returns a boolean indicating if it is sorted. - Move the sorting check logic from
IsSortedto this new core method. - Modify
IsSortedto call the new core method, or ideally, have the UI call the core method directly for validation. - Update any code that uses
IsSortedto align with the refactored structure. - Add or update tests for the core sorting validation logic.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request