Fix review comments

Author: paulteehan

soda-core/src/soda_core/common/data_source_connection.py

@@ -33,11 +33,6 @@ def _create_connection(self, connection_yaml_dict: dict) -> object:
         Exceptions do not need to be handled.  They will be handled by the calling method.
         """
 
-    def _post_connection_hook(self):
-        """
-        Called after connection is created, e.g. in case you need to modify the connection object (see Oracle).
-        """
-
     def open_connection(self) -> None:
         """
         Ensures that an open connection is available.
@@ -50,7 +45,6 @@ def open_connection(self) -> None:
             try:
                 logger.debug(f"'{self.name}' connection properties: {self.connection_properties}")
                 self.connection = self._create_connection(self.connection_properties)
-                self._post_connection_hook()
             except Exception as e:
                 logger.error(msg=f"Could not connect to '{self.name}': {e}", exc_info=True)
 

soda-core/src/soda_core/common/sql_ast.py

@@ -240,7 +240,7 @@ def __post_init__(self):
 
 @dataclass
 class COLUMN(SqlExpression):
-    name: SqlExpression | str  # Modified to allow SQL expressions, e.g. if you need to use a case statement to generate a column during SELECT
+    name: SqlExpression | str  # Use SqlExpression if you need to generate and/or rename a column dymamically, e.g. using a CASE statement
     table_alias: Optional[str] = None
     field_alias: Optional[str] = None
 

soda-core/src/soda_core/common/sql_dialect.py

@@ -346,7 +346,7 @@ def _build_column_sql(self, column: COLUMN) -> str:
         table_alias_sql: str = f"{self.quote_default(column.table_alias)}." if column.table_alias else ""
         column_sql: str = self.build_expression_sql(
             column.name
-        )  # Now supports any expression.  If string is passed, will default to old quote_default behavior
+        )  # If column.name is a SqlExpression, it will be compiled; if a string, it will be quoted
         field_alias_sql: str = f" AS {self.quote_default(column.field_alias)}" if column.field_alias else ""
         return f"{table_alias_sql}{column_sql}{field_alias_sql}"
 

soda-tests/tests/features/test_schema_check.py

@@ -109,8 +109,7 @@ def test_schema_errors(data_source_test_helper: DataSourceTestHelper):
         assert varchar(512) == length_mismatch.get_expected()
 
     type_mismatch = schema_check_result.column_data_type_mismatches[index_of_type_mismatch]
-    expected_data_type = data_type_map[DBDataType.DATE]
-    assert expected_data_type == type_mismatch.get_actual()
+    assert data_type_map[DBDataType.DATE] == type_mismatch.get_actual()
     assert data_type_map[DBDataType.TEXT] == type_mismatch.get_expected()