Add timestamp and timestamp_tz insert tests

Author: paulteehan

soda-core/src/soda_core/common/sql_dialect.py

@@ -554,7 +554,7 @@ def _build_tuple_sql(self, tuple: TUPLE) -> str:
         elements: str = ", ".join(self.build_expression_sql(e) for e in tuple.expressions)
         return f"({elements})"
 
-    def schema_information_schema(self) -> str:
+    def schema_information_schema(self) -> str | None:
         """
         Name of the schema that has the metadata
         """
@@ -605,9 +605,9 @@ def column_data_type(self) -> str:
         """
         return self.default_casify("data_type")
 
-    def column_data_type_max_length(self) -> str:
+    def column_data_type_max_length(self) -> str | COLUMN:
         """
-        Name of the column that has the max data type length in the tables metadata table.
+        Name or definition of the column that has the max data type length in the tables metadata table.
         Purpose of this method is to allow specific data source to override.
         """
         return self.default_casify("character_maximum_length")

soda-tests/tests/features/test_sql_ast_inserts.py

@@ -1,5 +1,5 @@
 import datetime
-
+import pytz
 from helpers.data_source_test_helper import DataSourceTestHelper
 from soda_core.common.data_source_impl import DataSourceImpl
 from soda_core.common.data_source_results import QueryResult
@@ -36,6 +36,8 @@ def test_full_create_insert_drop_ast(data_source_test_helper: DataSourceTestHelp
             CREATE_TABLE_COLUMN(name="name", type=DBDataType.TEXT, length=255, nullable=True),
             CREATE_TABLE_COLUMN(name="small_text", type=DBDataType.TEXT, length=3, nullable=True),
             CREATE_TABLE_COLUMN(name="my_date", type=DBDataType.DATE, nullable=True),
+            CREATE_TABLE_COLUMN(name="my_timestamp", type=DBDataType.TIMESTAMP, nullable=True),
+            CREATE_TABLE_COLUMN(name="my_timestamp_tz", type=DBDataType.TIMESTAMP_TZ, nullable=True),
         ]
 
         standard_columns = [column.convert_to_standard_column() for column in create_table_columns]
@@ -66,8 +68,26 @@ def test_full_create_insert_drop_ast(data_source_test_helper: DataSourceTestHelp
             INSERT_INTO(
                 fully_qualified_table_name=my_table_name,
                 values=[
-                    VALUES_ROW([LITERAL(1), LITERAL("John"), LITERAL("a"), LITERAL(datetime.date(2021, 1, 1))]),
-                    VALUES_ROW([LITERAL(2), LITERAL("Jane"), LITERAL("b"), LITERAL(datetime.date(2021, 1, 2))]),
+                    VALUES_ROW(
+                        [
+                            LITERAL(1),
+                            LITERAL("John"),
+                            LITERAL("a"),
+                            LITERAL(datetime.date(2021, 1, 1)),
+                            LITERAL(datetime.datetime(2021, 1, 1, 12, 10, 0)),
+                            LITERAL(datetime.datetime(2021, 1, 1, 12, 10, 0, tzinfo=datetime.timezone.utc)),
+                        ]
+                    ),
+                    VALUES_ROW(
+                        [
+                            LITERAL(2),
+                            LITERAL("Jane"),
+                            LITERAL("b"),
+                            LITERAL(datetime.date(2021, 1, 2)),
+                            LITERAL(datetime.datetime(2021, 1, 2, 12, 10, 0)),
+                            LITERAL(datetime.datetime(2021, 1, 2, 12, 10, 0, tzinfo=pytz.timezone("America/New_York"))),
+                        ]
+                    ),
                 ],
                 columns=standard_columns,
             )
@@ -94,6 +114,8 @@ def test_full_create_insert_drop_ast(data_source_test_helper: DataSourceTestHelp
                         COLUMN("name"),
                         COLUMN("small_text"),
                         COLUMN("my_date"),
+                        COLUMN("my_timestamp"),
+                        COLUMN("my_timestamp_tz"),
                     ]
                 ),
                 FROM(my_table_name[1:-1]),
@@ -116,6 +138,14 @@ def test_full_create_insert_drop_ast(data_source_test_helper: DataSourceTestHelp
         assert result.rows[1][3] in [datetime.date(2021, 1, 2), datetime.datetime(2021, 1, 2, 0, 0, 0)]
         assert result.rows[2][3] is None
 
+        assert result.rows[0][4] == datetime.datetime(2021, 1, 1, 12, 10, 0)
+        assert result.rows[1][4] == datetime.datetime(2021, 1, 2, 12, 10, 0)
+        assert result.rows[2][4] is None
+
+        assert result.rows[0][5] == datetime.datetime(2021, 1, 1, 12, 10, 0, tzinfo=datetime.timezone.utc)
+        assert result.rows[1][5] == datetime.datetime(2021, 1, 2, 12, 10, 0, tzinfo=pytz.timezone("America/New_York"))
+        assert result.rows[2][5] is None
+
     finally:
         # Then drop the table to clean up
         # We explicitly do not use the "if exists" variant, because the table should exist at this point.