Skip to content

types: type safer implementation and more accurate inference of return value type for shake#404

Open
AliubYiero wants to merge 1 commit into
sodiray:masterfrom
AliubYiero:fix-shake-return-type-error
Open

types: type safer implementation and more accurate inference of return value type for shake#404
AliubYiero wants to merge 1 commit into
sodiray:masterfrom
AliubYiero:fix-shake-return-type-error

Conversation

@AliubYiero

Copy link
Copy Markdown

Description

  • Type Fix: Fix the problem that the return value of shake() function is always a null object by TypeScript inference.
  • Comment Add: Sample code added to the JsDoc for the shake() function.

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the version in package.json has been bumped (matching semver)
  • If code changes were made, the yarn build command has been run and to update the cdn directory
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves #388

@vercel

vercel Bot commented May 5, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 1:52pm

@aleclarson

Copy link
Copy Markdown

Hi @AliubYiero, your fix is available in radashi@beta today (see #12). An official release is pending. We'd love to have you participate in the discussion and/or development of the radashi-org/radashi fork. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants