clean code

Author: Sönke Kluth

package.json

@@ -17,6 +17,9 @@
     "react": "15.3.2",
     "react-dom": "15.3.2"
   },
+  "eslintConfig": {
+    "extends": "react-app"
+  },
   "scripts": {
     "start": "react-scripts start",
     "build": "react-scripts build",

src/controller/CounterCommand.js

@@ -13,6 +13,8 @@ export default class CounterCommand extends SimpleCommand {
       case EventNames.SUBVIEW_LOCAL_COUNT:
         counter = this.facade.getProxy(CounterProxy.NAME_LOCAL);
         break;
+      default:
+        break;
     }
 
     if (counter) {

src/core/constants/NotificationNames.js

@@ -3,7 +3,7 @@ const NotificationNames = {
   DATA_CHANGE: 'DATA_CHANGE',
   RENDER: 'RENDER',
   STARTUP: 'STARTUP',
-  STARTUP_COMPLETE: 'STARTUP_COMPLETE'
+  STARTUP_COMPLETE: 'STARTUP_COMPLETE',
 };
 
 export default NotificationNames;

src/core/controller/DataChangeCommand.js

@@ -8,7 +8,7 @@ export default class DataChangeCommand extends SimpleCommand {
     localState[note.getType()] = data;
 
     const state = this.facade.getState();
-    if(Object.hasOwnProperty.call(state, note.getType())){
+    if (Object.hasOwnProperty.call(state, note.getType())) {
       this.facade.updateState(localState);
     }
   }

src/core/controller/StartupCommand.js

@@ -4,16 +4,16 @@ import { ModelPrepCommand, ViewPrepCommand } from '../../controller/prep-command
 
 export default class StartupCommand extends MacroCommand {
 
- initializeMacroCommand() {
-   this.addSubCommand(ModelPrepCommand);
-   this.addSubCommand(ViewPrepCommand);
- }
+  initializeMacroCommand() {
+    this.addSubCommand(ModelPrepCommand);
+    this.addSubCommand(ViewPrepCommand);
+  }
 
- execute(note) {
+  execute(note) {
    // console.log('StartupCommand execute()');
-   super.execute(note);
-   this.facade.removeCommand(NotificationNames.STARTUP);
-   this.facade.send(NotificationNames.RENDER);
- }
+    super.execute(note);
+    this.facade.removeCommand(NotificationNames.STARTUP);
+    this.facade.send(NotificationNames.RENDER);
+  }
 }
 

src/core/controller/StateChangeCommand.js

@@ -1,5 +1,4 @@
 import { SimpleCommand } from 'pmvc';
-import NotificationNames from '../constants/NotificationNames';
 
 export default class StateChangeCommand extends SimpleCommand {
   execute(note) {

src/core/utils/shallowEqual.js

@@ -1,23 +1,23 @@
 export default function shallowEqual(objA, objB) {
   if (objA === objB) {
-    return true
+    return true;
   }
 
-  const keysA = Object.keys(objA)
-  const keysB = Object.keys(objB)
+  const keysA = Object.keys(objA);
+  const keysB = Object.keys(objB);
 
   if (keysA.length !== keysB.length) {
-    return false
+    return false;
   }
 
   // Test for A's keys different from B.
-  const hasOwn = Object.prototype.hasOwnProperty
+  const hasOwn = Object.prototype.hasOwnProperty;
   for (let i = 0; i < keysA.length; i++) {
     if (!hasOwn.call(objB, keysA[i]) ||
         objA[keysA[i]] !== objB[keysA[i]]) {
-      return false
+      return false;
     }
   }
 
-  return true
+  return true;
 }

src/core/utils/storeShape.js

@@ -1,7 +1,7 @@
-import { PropTypes } from 'react'
+import { PropTypes } from 'react';
 
 export default PropTypes.shape({
   subscribe: PropTypes.func.isRequired,
   dispatch: PropTypes.func.isRequired,
-  getState: PropTypes.func.isRequired
-})
+  getState: PropTypes.func.isRequired,
+});

src/core/utils/warning.js

@@ -7,14 +7,14 @@
 export default function warning(message) {
   /* eslint-disable no-console */
   if (typeof console !== 'undefined' && typeof console.error === 'function') {
-    console.error(message)
+    console.error(message);
   }
   /* eslint-enable no-console */
   try {
     // This error was thrown as a convenience so that if you enable
     // "break on all exceptions" in your console,
     // it would pause the execution at this line.
-    throw new Error(message)
+    throw new Error(message);
     /* eslint-disable no-empty */
   } catch (e) {}
   /* eslint-enable no-empty */

src/core/utils/wrapActionCreators.js

@@ -1,6 +1,6 @@
 // import { bindActionCreators } from 'redux'
 
-export default function wrapActionCreators(actionCreators){
+export default function wrapActionCreators(actionCreators) {
   console.log('wrapActionCreators', actionCreators);
   // return dispatch => bindActionCreators(actionCreators, dispatch)
 }