Exception is thrown when component failed to register (#1361)

* Exception is thrown when component failed to register

Signed-off-by: JermaineHua <[email protected]>

* Fix testSofaServiceClassNotAssignableFromInterfaceType ut

Signed-off-by: JermaineHua <[email protected]>

* Fix testServiceBinding

Signed-off-by: JermaineHua <[email protected]>

* testBindingInstanceIsNotAssignableFromInterfaceType

Signed-off-by: JermaineHua <[email protected]>

---------

Signed-off-by: JermaineHua <[email protected]>

Author: CrazyHZM

sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/main/java/com/alipay/sofa/runtime/component/impl/ComponentManagerImpl.java

@@ -167,7 +167,7 @@ private ComponentInfo doRegister(ComponentInfo ci) {
             ci.register();
         } catch (Throwable t) {
             SofaLogger.error(ErrorCode.convert("01-03003", ci.getName()), t);
-            return null;
+            throw new ServiceRuntimeException(ErrorCode.convert("01-03003", ci.getName()));
         }
 
         SofaLogger.info("Registering component: {}", ci.getName());
@@ -189,6 +189,7 @@ private ComponentInfo doRegister(ComponentInfo ci) {
         } catch (Throwable t) {
             ci.exception(new Exception(t));
             SofaLogger.error(ErrorCode.convert("01-03004", ci.getName()), t);
+            throw new ServiceRuntimeException(ErrorCode.convert("01-03004", ci.getName()));
         }
 
         return ci;

sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/test/java/com/alipay/sofa/runtime/test/AnnotationSofaServiceTypeCheckFailTest.java

@@ -24,6 +24,7 @@
 import org.junit.AfterClass;
 import org.junit.Assert;
 import org.junit.Test;
+import org.springframework.beans.factory.BeanCreationException;
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.WebApplicationType;
 import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
@@ -68,7 +69,8 @@ public void testSofaServiceClassNotAssignableFromInterfaceType() throws IOExcept
             TestSofaServiceNotAssignableFromInterfaceTypeConfiguration.class);
         springApplication.setWebApplicationType(WebApplicationType.NONE);
         springApplication.setDefaultProperties(properties);
-        springApplication.run();
+
+        Assert.assertThrows(BeanCreationException.class, springApplication::run);
 
         String content = FileUtils.readFileToString(sofaLog, System.getProperty("file.encoding"));
         Assert

sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/test/java/com/alipay/sofa/runtime/test/ClientFactoryTest.java

@@ -134,7 +134,7 @@ public void testBindingInstanceIsNotAssignableFromInterfaceType() throws IOExcep
         serviceParam.setInstance(new Object());
         serviceParam.setInterfaceType(SampleService.class);
         serviceParam.addBindingParam(jvmBindingParam);
-        serviceClient.service(serviceParam);
+        Assert.assertThrows(Exception.class, ()-> serviceClient.service(serviceParam));
 
         String content = FileUtils.readFileToString(sofaLog, System.getProperty("file.encoding"));
         Assert

sofa-boot-project/sofa-boot-core/runtime-sofa-boot/src/test/java/com/alipay/sofa/runtime/test/XMLSofaServiceTypeCheckFailTest.java

@@ -66,7 +66,8 @@ public void testServiceBinding() throws IOException {
             SofaBindingTestIsNotAssignableFromInterfaceTypeConfiguration.class);
         springApplication.setWebApplicationType(WebApplicationType.NONE);
         springApplication.setDefaultProperties(properties);
-        springApplication.run();
+
+        Assert.assertThrows(Exception.class, springApplication::run);
 
         String content = FileUtils.readFileToString(sofaLog, System.getProperty("file.encoding"));
         Assert