fix(core): simplify file path handling in module and barrel file functions

Author: alilaa

packages/core/src/lib/modules/internal/find-module-paths-with-barrel.ts

@@ -11,11 +11,7 @@ export function findModulePathsWithBarrel(
     for (const projectDir of projectDirs) {
       const found = getFs().findFiles(projectDir, barrelFileName);
       for (const filePath of found) {
-        const lastSep = Math.max(
-          filePath.lastIndexOf('/'),
-          filePath.lastIndexOf('\\'),
-        );
-        modulePaths.add(filePath.substring(0, lastSep));
+        modulePaths.add(getFs().getParent(filePath));
       }
     }
   }

packages/core/src/lib/modules/internal/find-module-paths-without-barrel.ts

@@ -4,6 +4,7 @@ import {
   createModulePathPatternsTree,
   ModulePathPatternsTree,
 } from './create-module-path-patterns-tree';
+import * as path from 'path';
 import getFs from '../../fs/getFs';
 import { FOLDER_CHARACTERS_REGEX_STRING } from '../../tags/calc-tags-for-module';
 import { flattenModules } from './flatten-modules';
@@ -104,8 +105,7 @@ function hasBarrelFile(directory: FsPath, barrelFileNames: string[]): boolean {
   const children = fs.readDirectory(directory);
   return children.some((child) => {
     if (fs.isFile(child)) {
-      const lastSep = Math.max(child.lastIndexOf('/'), child.lastIndexOf('\\'));
-      const fileName = lastSep === -1 ? child : child.substring(lastSep + 1);
+      const fileName = path.basename(child);
       return barrelFileNames.some((pattern) => matchGlob(pattern, fileName));
     }
     return false;

packages/core/src/lib/modules/module.ts

@@ -1,6 +1,8 @@
 import { UnassignedFileInfo } from '../file-info/unassigned-file-info';
 import { FileInfo } from './file.info';
+import * as path from 'path';
 import { FsPath } from '../file-info/fs-path';
+import getFs from '../fs/getFs';
 import { matchGlob } from '../util/match-glob';
 
 /**
@@ -37,13 +39,8 @@ export class Module {
    * are not treated as barrel entries.
    */
   isBarrelFile(filePath: FsPath): boolean {
-    const lastSep = Math.max(
-      filePath.lastIndexOf('/'),
-      filePath.lastIndexOf('\\'),
-    );
-    const fileDir = lastSep === -1 ? '' : filePath.substring(0, lastSep);
-    const fileName =
-      lastSep === -1 ? filePath : filePath.substring(lastSep + 1);
+    const fileDir = getFs().getParent(filePath);
+    const fileName = path.basename(filePath);
 
     if (fileDir !== this.path) {
       return false;