fix(core): apply correct overload signatures for getEntriesFromCliOrConfig

Author: michaelbe812

packages/core/src/lib/cli/internal/get-entries-from-cli-or-config.ts

@@ -13,12 +13,23 @@ export type Entry<TEntry> = {
 
 export const DEFAULT_PROJECT_NAME = 'default';
 
+export function getEntriesFromCliOrConfig(
+  entryFileOrEntryPoints?: string,
+): Array<Entry<ProjectInfo>>;
+export function getEntriesFromCliOrConfig(
+  entryFileOrEntryPoints?: string,
+  runInit?: true,
+): Array<Entry<ProjectInfo>>;
+export function getEntriesFromCliOrConfig(
+  entryFileOrEntryPoints?: string,
+  runInit?: false,
+): Array<Entry<string>>;
 export function getEntriesFromCliOrConfig(
   /**
    * the CLI forwards either the entry file e.g. "src/main.ts" or
    * the entry point(s) e.g. app-i,app-ii
    */
-  entryFileOrEntryPoints?: string,
+  entryFileOrEntryPoints = '',
   runInit = true,
 ): Array<Entry<string>> | Array<Entry<ProjectInfo>> {
   const fs = getFs();
@@ -30,9 +41,7 @@ export function getEntriesFromCliOrConfig(
   if (entryFileOrEntryPoints) {
     // CLI argument given and no config file is present -> only entry file can work
     if (!fs.exists(potentialConfigFile)) {
-      return processEntryFile(entryFileOrEntryPoints as string, runInit, fs) as
-        | Array<Entry<string>>
-        | Array<Entry<ProjectInfo>>;
+      return processEntryFile(entryFileOrEntryPoints as string, runInit, fs);
     }
 
     if (fs.exists(potentialConfigFile)) {
@@ -46,14 +55,10 @@ export function getEntriesFromCliOrConfig(
 
       if (potentialEntryPoints) {
         // if entry points are given, return them
-        return processEntryFile(potentialEntryPoints, runInit, fs) as
-          | Array<Entry<string>>
-          | Array<Entry<ProjectInfo>>;
+        return processEntryFile(potentialEntryPoints, runInit, fs);
       } else {
         // otherwise it is an entry file
-        return processEntryFile(entryFileOrEntryPoints, runInit, fs) as
-          | Array<Entry<string>>
-          | Array<Entry<ProjectInfo>>;
+        return processEntryFile(entryFileOrEntryPoints, runInit, fs);
       }
     }
   }
@@ -68,16 +73,12 @@ export function getEntriesFromCliOrConfig(
     }
 
     if (sheriffConfig.entryFile) {
-      return processEntryFile(sheriffConfig.entryFile, runInit, fs) as
-        | Array<Entry<string>>
-        | Array<Entry<ProjectInfo>>;
+      return processEntryFile(sheriffConfig.entryFile, runInit, fs);
     } else if (
       sheriffConfig.entryPoints &&
       !isEmptyRecord(sheriffConfig.entryPoints)
     ) {
-      return processEntryFile(sheriffConfig.entryPoints, runInit, fs) as
-        | Array<Entry<string>>
-        | Array<Entry<ProjectInfo>>;
+      return processEntryFile(sheriffConfig.entryPoints, runInit, fs);
     } else {
       throw new Error(
         'No entry file or entry points found in sheriff.config.ts. Please provide the option via the CLI.',
@@ -109,13 +110,13 @@ function processEntryFile(
     const entries = Object.entries(entryFileValue);
 
     return runInit
-      ? entries.map(([projectName, entry]) => ({
+      ? (entries.map(([projectName, entry]) => ({
           projectName,
           entry: init(toFsPath(fs.join(fs.cwd(), entry as string))),
-        }))
-      : entries.map(([projectName, entry]) => ({
+        })) as Array<Entry<ProjectInfo>>)
+      : (entries.map(([projectName, entry]) => ({
           projectName,
           entry: entry as string,
-        }));
+        })) as Array<Entry<string>>);
   }
 }