feat: only Report ESLint errors for unresolvable Relative Imports #237

Author: msari-ipe-ext-1

packages/core/src/lib/eslint/tests/violates-dependency-rule.spec.ts

@@ -119,6 +119,25 @@ describe('violates dependency rules', () => {
     ).toBe('import ./app.component cannot be resolved');
   });
 
+  it('should not report unresolvable external library import', () => {
+    createProject({
+      'tsconfig.json': tsConfig(),
+      'sheriff.config.ts': sheriffConfig({ modules: {}, depRules: {} }),
+      src: {
+        'main.ts': ['node:fs'],
+      },
+    });
+
+    expect(
+      violatesDependencyRule(
+        '/project/src/main.ts',
+        'node:fs',
+        true,
+        getFs().readFile(toFsPath('/project/src/main.ts')),
+      ),
+    ).toBe('');
+  });
+
   it('should ignore json imports  ', () => {
     const fs = createProject({
       'tsconfig.json': tsConfig(),

packages/core/src/lib/eslint/tests/violates-encapsulation-rule.spec.ts

@@ -78,6 +78,25 @@ describe('encapsulation', () => {
     ).toBe('import ./app/app.component cannot be resolved');
   });
 
+  it('should not report unresolvable external library import', () => {
+    testInit('src/main.ts', {
+      'tsconfig.json': tsConfig(),
+      src: {
+        'main.ts': ['keycloak-js'],
+      },
+    });
+
+    expect(
+      violatesEncapsulationRule(
+        '/project/src/main.ts',
+        'keycloak-js',
+        true,
+        getFs().readFile(toFsPath('/project/src/main.ts')),
+        true,
+      ),
+    ).toBe('');
+  });
+
   it('should return a violation to a barrel-less modules', () => {
     testInit('src/app/main.ts', {
       'tsconfig.json': tsConfig(),

packages/core/src/lib/eslint/violates-dependency-rule.ts

@@ -7,6 +7,7 @@ import {
   DependencyRuleViolation,
 } from '../checks/check-for-dependency-rule-violation';
 import { FileInfo } from '../modules/file.info';
+import { isRelativeImport } from '../util/is-relative-import';
 
 let cache: Record<string, string> = {};
 let cacheActive = false;
@@ -55,7 +56,10 @@ export const violatesDependencyRule = (
     }
   }
 
-  if (throwIfNull(fileInfo).isUnresolvableImport(importCommand)) {
+  if (
+    throwIfNull(fileInfo).isUnresolvableImport(importCommand) &&
+    isRelativeImport(importCommand)
+  ) {
     return `import ${importCommand} cannot be resolved`;
   }
 

packages/core/src/lib/eslint/violates-encapsulation-rule.ts

@@ -2,6 +2,7 @@ import { toFsPath } from '../file-info/fs-path';
 import { init } from '../main/init';
 import { hasEncapsulationViolations } from '../checks/has-encapsulation-violations';
 import { FileInfo } from '../modules/file.info';
+import { isRelativeImport } from '../util/is-relative-import';
 
 let cache: Record<string, FileInfo> = {};
 let cachedFileInfo: FileInfo | undefined;
@@ -48,7 +49,10 @@ export const violatesEncapsulationRule = (
     cache = hasEncapsulationViolations(fsPath, projectInfo);
   }
 
-  if (cachedFileInfo.isUnresolvableImport(importCommand)) {
+  if (
+    cachedFileInfo.isUnresolvableImport(importCommand) &&
+    isRelativeImport(importCommand)
+  ) {
     return `import ${importCommand} cannot be resolved`;
   }
 

packages/core/src/lib/util/is-relative-import.ts

@@ -0,0 +1,20 @@
+/**
+ * Determines whether an import command is a relative import.
+ *
+ * Relative imports are those that start with a dot (e.g. './x', '../y').
+ * Non-relative imports include:
+ * - External packages (e.g. 'keycloak-js')
+ * - Node.js built-in modules (e.g. 'node:url', 'fs', 'path')
+ *
+ * Sheriff ESLint rules only report unresolvable imports when they are relative.
+ * This avoids false positives for external packages and Node built-ins while
+ * still allowing the core to track all unresolvable imports for data/export.
+ *
+ * @param importCommand The raw import string as it appears in source code
+ * @returns true if the import is relative; otherwise false
+ */
+export function isRelativeImport(importCommand: string): boolean {
+  return importCommand.startsWith('.');
+}
+
+