Fix scrape listener registration

Author: josemanuel-cardona

src/Scraper/Listeners/ScrapedListener.php

@@ -15,10 +15,8 @@ public function __construct($listeners)
 
     public function handle(Scraped $scraped)
     {
-        if (!isset($this->listeners[$scraped->scrapeRequest->type])) {
-            throw new \InvalidArgumentException();
+        if (isset($this->listeners[$scraped->scrapeRequest->type])) {
+            resolve($this->listeners[$scraped->scrapeRequest->type])->handle($scraped);
         }
-
-        resolve($this->listeners[$scraped->scrapeRequest->type])->handle($scraped);
     }
 }

src/ScraperProvider.php

@@ -29,7 +29,7 @@ class ScraperProvider extends EventServiceProvider
         ],
         Scraped::class              => [
             UpdateDataset::class,
-            ScrapedListener::class
+            ScrapedListener::class,
         ],
         ConfigurationScraped::class => [
             UpdateDataset::class,
@@ -71,5 +71,11 @@ public function register()
             ->give(function () {
                 return config('scraper.xpath.ignore-identifiers');
             });
+
+        $this->app->when(ScrapedListener::class)
+            ->needs('$listeners')
+            ->give(function () {
+                return config('scraper.listeners');
+            });
     }
 }

tests/Unit/Scraper/Listeners/ScrapedListenerTest.php

@@ -2,7 +2,6 @@
 
 namespace Softonic\LaravelIntelligentScraper\Scraper\Listeners;
 
-use Mockery\Mock;
 use Softonic\LaravelIntelligentScraper\Scraper\Events\Scraped;
 use Softonic\LaravelIntelligentScraper\Scraper\Events\ScrapeRequest;
 use Tests\TestCase;
@@ -12,8 +11,14 @@ class ScrapedListenerTest extends TestCase
     /**
      * @test
      */
-    public function whenReceiveAnUnknownScrapedTypeItShouldThrowAnException(){
-        $scrapedListener = new ScrapedListener([]);
+    public function whenReceiveAnUnknownScrapedTypeItShouldDoNothing()
+    {
+        $listener = \Mockery::mock(ScrapedListener::class);
+        \App::instance(get_class($listener), $listener);
+
+        $scrapedListener = new ScrapedListener([
+            'known_type' => get_class($listener),
+        ]);
 
         $scrapedEvent = new Scraped(
             new ScrapeRequest(
@@ -24,20 +29,21 @@ public function whenReceiveAnUnknownScrapedTypeItShouldThrowAnException(){
             1
         );
 
-        $this->expectException(\InvalidArgumentException::class);
+        $listener->shouldNotReceive('handle');
 
         $scrapedListener->handle($scrapedEvent);
     }
 
     /**
      * @test
      */
-    public function whenReceiveAKnownScrapedTypeItShouldHandleTheEventWithTheSpecificDependency(){
+    public function whenReceiveAKnownScrapedTypeItShouldHandleTheEventWithTheSpecificDependency()
+    {
         $listener = \Mockery::mock(ScrapedListener::class);
         \App::instance(get_class($listener), $listener);
 
         $scrapedListener = new ScrapedListener([
-            'known_type' => get_class($listener)
+            'known_type' => get_class($listener),
         ]);
 
         $scrapedEvent = new Scraped(