migrate updateMoneyRequestAmountAndCurrency

Author: Guccio163

config/eslint/eslint.seatbelt.tsv

@@ -831,7 +831,7 @@
 "../../src/libs/actions/IOU/TrackExpense.ts"	"@typescript-eslint/no-unsafe-type-assertion"	2
 "../../src/libs/actions/IOU/TrackExpense.ts"	"no-restricted-syntax"	2
 "../../src/libs/actions/IOU/UpdateMoneyRequest.ts"	"@typescript-eslint/no-deprecated/buildNextStepNew"	1
-"../../src/libs/actions/IOU/UpdateMoneyRequest.ts"	"@typescript-eslint/no-deprecated/getPolicyTagsData"	13
+"../../src/libs/actions/IOU/UpdateMoneyRequest.ts"	"@typescript-eslint/no-deprecated/getPolicyTagsData"	12
 "../../src/libs/actions/IOU/UpdateMoneyRequest.ts"	"@typescript-eslint/no-unsafe-type-assertion"	2
 "../../src/libs/actions/IOU/UpdateMoneyRequest.ts"	"no-restricted-syntax"	1
 "../../src/libs/actions/IOU/index.ts"	"@typescript-eslint/no-deprecated/getMoneyRequestPolicyTags"	1

src/libs/actions/IOU/UpdateMoneyRequest.ts

@@ -1261,6 +1261,7 @@ type UpdateMoneyRequestAmountAndCurrencyParams = {
     parentReportNextStep: OnyxEntry<OnyxTypes.ReportNextStepDeprecated>;
     hash?: number;
     delegateAccountID: number | undefined;
+    reportPolicyTags: OnyxEntry<OnyxTypes.PolicyTagLists>;
 };
 
 /** Updates the amount and currency fields of an expense */
@@ -1286,6 +1287,7 @@ function updateMoneyRequestAmountAndCurrency({
     parentReportNextStep,
     hash,
     delegateAccountID,
+    reportPolicyTags,
 }: UpdateMoneyRequestAmountAndCurrencyParams) {
     const transactionChanges = {
         amount,
@@ -1307,8 +1309,7 @@ function updateMoneyRequestAmountAndCurrency({
             transactionChanges,
             policy,
             policyTagList,
-            // TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
-            reportPolicyTags: getPolicyTagsData(parentReport?.policyID),
+            reportPolicyTags,
             policyCategories: policyCategories ?? null,
             allowNegative,
             currentUserAccountIDParam,

src/libs/actions/TransactionInlineEdit.ts

@@ -54,6 +54,7 @@ import type {
     Transaction,
     TransactionViolations,
 } from '@src/types/onyx';
+import {getPolicyTagsData} from './IOU';
 import {
     updateMoneyRequestAmountAndCurrency,
     updateMoneyRequestCategory,
@@ -355,6 +356,9 @@ function editTransactionAmountInline(params: TransactionInlineEditParams, newAmo
     const taxPercentage = getTaxValue(iouParams.policy, iouParams.transaction, taxCode) ?? '';
     const decimals = getCurrencyDecimals(getCurrency(iouParams.transaction));
     const taxAmount = convertToBackendAmount(calculateTaxAmount(taxPercentage, newAmount, decimals));
+    // TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
+    const reportPolicyTags = getPolicyTagsData(iouParams.parentReport?.policyID);
     updateMoneyRequestAmountAndCurrency({
         ...iouParams,
         amount: newAmount,
@@ -367,6 +371,7 @@ function editTransactionAmountInline(params: TransactionInlineEditParams, newAmo
         transactionViolations: allTransactionViolations,
         policyRecentlyUsedCurrencies: [],
         hash: params.hash,
+        reportPolicyTags,
     });
 }
 

src/pages/iou/request/step/AmountSubmission.ts

@@ -21,6 +21,7 @@ import Permissions from '@libs/Permissions';
 import {getPolicyExpenseChat, getTransactionDetails, isMoneyRequestReport, isSelfDM, shouldEnableNegative} from '@libs/ReportUtils';
 import shouldUseDefaultExpensePolicy from '@libs/shouldUseDefaultExpensePolicy';
 import {calculateTaxAmount, getAmount, getCurrency, getDefaultTaxCode, getIsFromGlobalCreate, getTaxValue, hasReceipt} from '@libs/TransactionUtils';
+import {getPolicyTagsData} from '@userActions/IOU';
 import {
     getMoneyRequestParticipantsFromReport,
     setMoneyRequestAmount,
@@ -544,6 +545,9 @@ function submitAmount({
     // `TRANSACTION_VIOLATIONS` at module scope.
     const parentReport = report?.parentReportID ? allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${report.parentReportID}`] : undefined;
 
+    // TODO: Replace getPolicyTagsData (https://github.com/Expensify/App/issues/72721) with useOnyx hook
+    // eslint-disable-next-line @typescript-eslint/no-deprecated
+    const reportPolicyTags = getPolicyTagsData(parentReport?.policyID);
     updateMoneyRequestAmountAndCurrency({
         transactionID,
         transactionThreadReport: report,
@@ -563,6 +567,7 @@ function submitAmount({
         isASAPSubmitBetaEnabled,
         policyRecentlyUsedCurrencies: policyRecentlyUsedCurrencies ?? [],
         delegateAccountID,
+        reportPolicyTags,
     });
     navigateBack();
 }

tests/actions/IOUTest/DeleteMoneyRequestTest.ts

@@ -677,6 +677,7 @@ describe('actions/IOU/DeleteMoneyRequest', () => {
                     transactionThreadReport: thread,
                     parentReport: iouReport,
                     transactionViolations: {},
+                    reportPolicyTags: undefined,
                     amount: 20000,
                     currency: CONST.CURRENCY.USD,
                     taxAmount: 0,

tests/actions/IOUTest/UpdateMoneyRequestTest.ts

@@ -406,6 +406,7 @@ describe('actions/IOU/UpdateMoneyRequest', () => {
                 transactionID: fakeTransaction.transactionID,
                 transactionThreadReport: fakeReport,
                 parentReport: undefined,
+                reportPolicyTags: undefined,
                 amount: 20000,
                 currency: CONST.CURRENCY.USD,
                 taxAmount: 0,
@@ -477,6 +478,7 @@ describe('actions/IOU/UpdateMoneyRequest', () => {
                 transactionID: fakeTransaction.transactionID,
                 transactionThreadReport: fakeReport,
                 parentReport: undefined,
+                reportPolicyTags: undefined,
                 amount: 20000,
                 currency: CONST.CURRENCY.USD,
                 taxAmount: 0,
@@ -631,6 +633,7 @@ describe('actions/IOU/UpdateMoneyRequest', () => {
                 transactionID,
                 transactionThreadReport: transactionThread,
                 parentReport: expenseReport,
+                reportPolicyTags: undefined,
                 amount: 20000,
                 currency: CONST.CURRENCY.USD,
                 taxAmount: 0,