Merge pull request Expensify#92774 from callstack-internal/refactor/hoist-isparticipantp2p

[NOQA] refactor: hoist isParticipantP2P into IOUUtils

Author: cristipaval

src/components/MoneyRequestConfirmationList/sections/AmountField.tsx

@@ -12,11 +12,10 @@ import useOnyx from '@hooks/useOnyx';
 import useThemeStyles from '@hooks/useThemeStyles';
 import {clearMoneyRequestAmount, getMoneyRequestParticipantsFromReport, setMoneyRequestAmount, setMoneyRequestTaxAmount, setMoneyRequestTaxRate} from '@libs/actions/IOU/MoneyRequest';
 import {convertToBackendAmount, convertToFrontendAmountAsString, getLocalizedCurrencySymbol} from '@libs/CurrencyUtils';
-import {calculateAmount, isMovingTransactionFromTrackExpense} from '@libs/IOUUtils';
+import {calculateAmount, isMovingTransactionFromTrackExpense, isParticipantP2P} from '@libs/IOUUtils';
 import Navigation from '@libs/Navigation/Navigation';
 import {shouldEnableNegative} from '@libs/ReportUtils';
 import {calculateTaxAmount, getTaxCode, getTaxValue} from '@libs/TransactionUtils';
-import {isParticipantP2P} from '@pages/iou/request/step/IOURequestStepAmount';
 import IOURequestStepCurrencyModal from '@pages/iou/request/step/IOURequestStepCurrencyModal';
 import {resetSplitShares, setDraftSplitTransaction, setSplitShares} from '@userActions/IOU/Split';
 import CONST from '@src/CONST';

src/libs/IOUUtils.ts

@@ -513,6 +513,14 @@ function resolveReportForMoneyRequest({
     return routeReport;
 }
 
+/**
+ * Check whether a money-request participant represents a P2P chat (i.e. another user, not a
+ * policy-expense chat and not a self DM).
+ */
+function isParticipantP2P(participant: {accountID?: number; isPolicyExpenseChat?: boolean; isSelfDM?: boolean} | undefined): boolean {
+    return !!(participant?.accountID && !participant.isPolicyExpenseChat && !participant.isSelfDM);
+}
+
 export {
     calculateAmount,
     calculateSplitAmountFromPercentage,
@@ -531,6 +539,7 @@ export {
     calculateDefaultReimbursable,
     getInitialPerDiemTargetReport,
     getIsWorkspacesOnlyForTransaction,
+    isParticipantP2P,
     resolveOptimisticChatReportID,
     resolveReportForMoneyRequest,
 };

src/pages/iou/request/step/IOURequestStepAmount.tsx

@@ -30,6 +30,7 @@ import {
     calculateDefaultReimbursable,
     getExistingTransactionID,
     isMovingTransactionFromTrackExpense,
+    isParticipantP2P,
     navigateToConfirmationPage,
     navigateToParticipantPage,
     resolveOptimisticChatReportID,
@@ -581,13 +582,6 @@ function IOURequestStepAmount({
     );
 }
 
-/**
- * Check if the participant is a P2P chat
- */
-function isParticipantP2P(participant: {accountID?: number; isPolicyExpenseChat?: boolean; isSelfDM?: boolean} | undefined): boolean {
-    return !!(participant?.accountID && !participant.isPolicyExpenseChat && !participant.isSelfDM);
-}
-
 const IOURequestStepAmountWithWritableReportOrNotFound = withWritableReportOrNotFound(IOURequestStepAmount, true);
 
 const IOURequestStepAmountWithFullTransactionOrNotFound = withFullTransactionOrNotFound(IOURequestStepAmountWithWritableReportOrNotFound, true);
@@ -596,4 +590,4 @@ const IOURequestStepAmountWithFullTransactionOrNotFound = withFullTransactionOrN
 const IOURequestStepAmountWithTransactionOnly = withFullTransactionOrNotFound(IOURequestStepAmount, true);
 
 export default IOURequestStepAmountWithFullTransactionOrNotFound;
-export {isParticipantP2P, IOURequestStepAmountWithTransactionOnly};
+export {IOURequestStepAmountWithTransactionOnly};

tests/unit/IOURequestStepAmountTest.ts

@@ -944,3 +944,62 @@ describe('getExistingTransactionID', () => {
         });
     });
 });
+
+describe('isParticipantP2P', () => {
+    it('should return true for P2P participant with accountID and isPolicyExpenseChat false', () => {
+        const participant = {
+            accountID: 123,
+            isPolicyExpenseChat: false,
+        };
+
+        expect(IOUUtils.isParticipantP2P(participant)).toBe(true);
+    });
+
+    it('should return false when participant is undefined', () => {
+        expect(IOUUtils.isParticipantP2P(undefined)).toBe(false);
+    });
+
+    it('should return false when participant has no accountID', () => {
+        const participant = {
+            isPolicyExpenseChat: false,
+        };
+
+        expect(IOUUtils.isParticipantP2P(participant)).toBe(false);
+    });
+
+    it('should return false when participant is a policy expense chat', () => {
+        const participant = {
+            accountID: 123,
+            isPolicyExpenseChat: true,
+        };
+
+        expect(IOUUtils.isParticipantP2P(participant)).toBe(false);
+    });
+
+    it('should return false when accountID is 0', () => {
+        const participant = {
+            accountID: 0,
+            isPolicyExpenseChat: false,
+        };
+
+        expect(IOUUtils.isParticipantP2P(participant)).toBe(false);
+    });
+
+    it('should return true for P2P participant without isPolicyExpenseChat property', () => {
+        const participant = {
+            accountID: 456,
+        };
+
+        expect(IOUUtils.isParticipantP2P(participant)).toBe(true);
+    });
+
+    it('should return false for self-DM participant', () => {
+        const participant = {
+            accountID: 123,
+            isPolicyExpenseChat: false,
+            isSelfDM: true,
+        };
+
+        expect(IOUUtils.isParticipantP2P(participant)).toBe(false);
+    });
+});